Closed Bug 2016754 Opened 1 month ago Closed 1 month ago

Add additional test coverage for tabs.move and split views

Categories

(WebExtensions :: Frontend, task, P2)

Product:
WebExtensions
Component:
Frontend
Type:
task

Tracking

(firefox149 fixed)

Status:
RESOLVED FIXED
Milestone:
149 Branch
Tracking Flags:
Tracking Status
firefox149 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [addons-jira])

Attachments

(1 file)

Bug 2016754 - Add unit tests for tabs.move() and split views
48 bytes, text/x-phabricator-request
Details | Review

I added some basic tests for tabs.move() with splitViewId in bug 1993037, but noticed that we still need coverage for non-trivial situations:

  • moving tabs of a split view to a different window
  • moving tabs of a split view within a window
  • moving tabs within a split view.

I have already started authoring the unit tests, and will attach the patch here. They reveal surprising behavior in some cases, which will require some follow-ups.

See Also: → 2016868

These tests test the following scenarios, which are currently not
behaving as desired. Separate bugs exist to fix them, as immediate
follow-ups:

  • Moving tabs within windows, with TODO bug 2016762 as follow-up.

  • Moving tabs across window, with TODO bug 2017148 as follow-up.

Blocks: 2016762, 2017148
Severity: -- → N/A
Priority: -- → P2

https://hg.mozilla.org/mozilla-central/rev/6a906029902b

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox149: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
You need to log in before you can comment on or make changes to this bug.