Issue 148810044: code review 148810044: windows: fix wrong home directory

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 148810044: code review 148810044: windows: fix wrong home directory

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by jfrederich

Modified:
11 years, 5 months ago

Reviewers:
r, rsc

Visibility:
Public.

Description

windows: fix wrong home directory On Windows $HOME is defined as combination of %HOMEDRIVE% and %HOMEPATH%. Fixes issue 6.

Patch Set 1 #

Patch Set 2 : diff -r 24df7a1a1bd03971c9dbc5408723b32527d62b94 https://code.google.com/p/codesearch #

Patch Set 3 : diff -r 24df7a1a1bd03971c9dbc5408723b32527d62b94 https://code.google.com/p/codesearch #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	index/merge.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	index/read.go	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2014/09/19 12:16:07, jfrederich wrote: > Hello mailto:r@golang.org, mailto:rsc@golang.org, > > I'd like you to review this change to > https://code.google.com/p/codesearch gentle ping

Expand All Messages | Collapse All Messages