Skip to main content
8 events
when toggle format what by license comment
Apr 13, 2017 at 12:41 history edited CommunityBot
replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Jul 21, 2014 at 15:53 comment added user73428 You can also take into account that it's likely that if you do touch one one major part, with a fair (not monster) size review, it will be up-voted equally, and other will add their own answers, simply noting the points you already made. The result? - 1) You ensure that the asker feels happy that he got a quick response - 2) The question ultimately gets a more complete answer in total, because everyone was able to focus on specific aspects of the code.
Jul 21, 2014 at 11:18 comment added nhgrif @jt0dd The problem is that a) that's still an "incomplete" review, and b) what one person sees as a structural issue another person may not. I might write a review about the massive structural issue and decide to wait until the repost for the other issues, but that doesn't prevent other answerers from posting the monster answers that address all of the individual issues.
Jul 21, 2014 at 2:01 comment added RubberDuck "I think it's probably best if the question instead has several good answers that each address a specific topic." - We need more of that, rather than trying to write absolutely complete reviews that turn into walls of text that very few people read.
Jul 21, 2014 at 0:50 comment added user73428 And how about we learn to review in stages? "This has structural issues. Fix them as follows. [...] There are more formatting and optimization issue that I'd like to touch on, but this is enough for now." And leave it to the OP to post his code again when the structure is right.
Jul 21, 2014 at 0:38 comment added user73428 I posted a long answer just now (my first); My meaning was not that long answers were not often necessary, but rather that if you have little to say about the code, a thumbs up and few sentences can be the difference between the asker believing that his question is ignored and being happy that he did a pretty good job. Notice in my answer, although it was long, I didn't rewrite much of his code at all.
Jul 21, 2014 at 0:33 comment added nhgrif For an answer that started as a comment... whoa this is big...
Jul 21, 2014 at 0:32 history answered nhgrif CC BY-SA 3.0