Timeline for Can you show me how to apply a specific strategy to my working code to improve it
Current License: CC BY-SA 4.0
6 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| May 3, 2018 at 21:01 | comment | added | Raystafarian | I think you make a good point, and I don't think it's a point lost on any of us. You want to improve, you bring us the most basic version that does what you want - it's up to use to show the cases that won't work, how using objects would be better, what the style guides say. Asker's intent was that they got it to work but know they can improve. A-OK. But if you come in saying "I can't get x case to work" then it's off-topic. The simple difference is that we cannot review something that doesn't work - it needs to be fixed, not reviewed. | |
| May 3, 2018 at 17:03 | comment | added | user106363 | @rolfl that's why I mention culture. Those questions could not be technically wrong due to rules depending on the english around it and what part of the question in stressed, but if it can realistically go on SO and get answered then it shouldn't be here. This does require users to understand what SO is, but I think it's worth far more than trying to write a good rule book or agree on "rulings" for question type. Also we should probably ask SE for a "Help me write code" website. I've heard complaints from people about that in every programming SE sight I've been on. Just give its own site. | |
| May 3, 2018 at 16:59 | comment | added | rolfl Mod | The "one of those is SO" answer is why this question is so subtle. If the user asks for help implementing something specific, then it's no longer a code-review, and it's off-topic on this site - since the user needs help writing code, not help reviewing the new code. | |
| May 3, 2018 at 16:33 | comment | added | user106363 | @rolfl One of those is an SO question. One isn't. The second case could be on this site though IMO. If they're asking about how to do something in a paradigm they suck at and it's clear in the code that what they tried to implement is garbage then there's an argument for including it, just based on my guess that SO would not handle that at all given their whole "we're not here to code for you" excuse. There's also the question of where a fix goes in your code. I've spent waaaaay too much time reordering my code just so it's easier to read. When it works it's worth it. | |
| May 3, 2018 at 14:48 | comment | added | rolfl Mod | Note, the following scenarios are very different in my mind: "Are there any edge cases I am missing?" vs. "I know there's this one edge case I am missing, how do I fix it?" Are those situations both on topic then? In my opinion, the first case is on-topic, but the second one is off-topic (the code does not work as intended). | |
| May 3, 2018 at 14:05 | history | answered | user106363 | CC BY-SA 4.0 |