Timeline for Changing the view based on these if/else statements
Current License: CC BY-SA 3.0
14 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Dec 29, 2017 at 3:24 | vote | accept | Ryan | ||
| Dec 28, 2017 at 22:45 | answer | added | Igor Soloydenko | timeline score: 1 | |
| Dec 28, 2017 at 20:56 | comment | added | JasonInVegas | Here's the issue I see, which may be the source of 'confusion' others comment on: You are using four different parameters to control a state machine with 2 states. Consider using a state machine pattern (yes, even in javascript) where your 'mode' can transition from EDIT to DISPLAY as conditions change. What I read in your code says that status isn't needed at all, stage may not be needed either. The machine can likely be driven entirely by the values in 'code' and 'response' variables. | |
| Dec 28, 2017 at 20:27 | answer | added | A Bravo Dev | timeline score: 3 | |
| Dec 28, 2017 at 20:04 | history | edited | Malachi | CC BY-SA 3.0 | fixed the ordered list formatting |
| Dec 28, 2017 at 20:01 | answer | added | Malachi | timeline score: 1 | |
| Dec 28, 2017 at 19:50 | comment | added | Conor Mancone | Short of using guards, there isn't much to be cleaned up here. Again, I can just about promise that the reason why this seems confusing is because the rest of your code is confusing, and any changes suggested as a result of what you have posted will be nothing more than superficial. If you want to really get some help here, then post more code. | |
| Dec 28, 2017 at 19:43 | history | edited | Ryan | CC BY-SA 3.0 | Title change, text edits |
| Dec 28, 2017 at 19:41 | comment | added | Ryan | It's too much to explain in the title, so I thought stating the goal of my post was better. It's just a matter of cleaning up these if statements; I've given a decent amount of context here. Edit: There isn't a problem anywhere in the code and I stated that it works. It's merely that this is confusing. | |
| S Dec 28, 2017 at 19:39 | history | suggested | Arun Vinoth PrecogTechnologies | CC BY-SA 3.0 | just arranged in list |
| Dec 28, 2017 at 19:34 | comment | added | Conor Mancone | You haven't given us anywhere near enough code to help. Here at code review, the more code you post the better. Looking at this I can tell you with a very high degree of certainty that your problem isn't these few lines of code but that your controllers are a jumbled mess. We can't even see the declaration/initialization of the variables that are being used in this block of code. Post everything and then update your title to explain what the code is supposed to do. Then we can do something for you. | |
| Dec 28, 2017 at 19:33 | review | Suggested edits | |||
| S Dec 28, 2017 at 19:39 | |||||
| Dec 28, 2017 at 19:25 | review | First posts | |||
| Dec 28, 2017 at 19:27 | |||||
| Dec 28, 2017 at 19:22 | history | asked | Ryan | CC BY-SA 3.0 |