Timeline for Shoe shine shop model in Rust
Current License: CC BY-SA 4.0
21 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Nov 14, 2019 at 12:54 | comment | added | pacmaninbw♦ | If you want to get a second review, the preferred way is start a new question and link it back to this question. | |
| Nov 14, 2019 at 12:50 | history | rollback | Martin R | Rollback to Revision 3 | |
| Nov 14, 2019 at 12:26 | comment | added | pacmaninbw♦ | Please don't edit the question after it has been answered, the point is to allow every reviewer to see the same code. For more information see this help page codereview.stackexchange.com/help/someone-answers | |
| Nov 14, 2019 at 12:23 | history | rollback | pacmaninbw♦ | Rollback to Revision 4 | |
| Nov 14, 2019 at 11:00 | history | edited | rogday | CC BY-SA 4.0 | added 236 characters in body |
| Nov 13, 2019 at 20:10 | history | edited | rogday | CC BY-SA 4.0 | added 17669 characters in body |
| Nov 10, 2019 at 23:21 | comment | added | rogday | @winston-ewert It's allowed to receive a client on the first chair while the second is occupied. "BOTH" state means both clients are getting served. "WAITING" means client on the first chair awaits for the other one to finish. | |
| S Nov 10, 2019 at 22:10 | history | suggested | Bergi | CC BY-SA 4.0 | syntax highlighting |
| Nov 10, 2019 at 18:32 | review | Suggested edits | |||
| S Nov 10, 2019 at 22:10 | |||||
| Nov 10, 2019 at 14:44 | comment | added | trent | I took another look this morning and I now think both versions are solving the wrong problem. I edited my answer with details. Hope this helps! | |
| Nov 10, 2019 at 12:00 | history | tweeted | twitter.com/StackCodeReview/status/1193498664825761794 | ||
| Nov 10, 2019 at 11:03 | vote | accept | rogday | ||
| Nov 10, 2019 at 10:49 | answer | added | RubberDuck | timeline score: 7 | |
| Nov 10, 2019 at 6:06 | comment | added | Winston Ewert | You seem to transition to the Both state if the client leaves while the left-shoe is being shined? But it would seem that the second shoe wouldn't be shined in that case, so its odd to call it Both. And I can't figure out any logic to the transition to the First or Waiting states from that state. | |
| Nov 10, 2019 at 6:04 | comment | added | Winston Ewert | It seems to me that your use of a state transition table is very C++ and not really in keeping with Rust style. I'd like to offer more concrete advice, but I'm having trouble understanding the logic of your table. I'd have thought it would Invalid to Arrive when not in the empty state. But you either transition to Dropping or Both. I'm guessing that Dropping means that the client left before the shoe shine was finished, and you are interpreting "Arrive" in a non-empty state as "Depart." But then I can't figure out what the Both state is doing. | |
| Nov 10, 2019 at 0:16 | history | became hot network question | |||
| Nov 10, 2019 at 0:07 | answer | added | trent | timeline score: 16 | |
| Nov 9, 2019 at 17:44 | answer | added | pacmaninbw♦ | timeline score: 10 | |
| Nov 9, 2019 at 16:17 | history | edited | pacmaninbw♦ | Added the comparative review tag. | |
| Nov 9, 2019 at 16:10 | review | First posts | |||
| Nov 9, 2019 at 23:52 | |||||
| Nov 9, 2019 at 16:07 | history | asked | rogday | CC BY-SA 4.0 |