Skip to main content
added 44 characters in body
Source Link
magulla
  • 181
  • 1
  • 1
  • 7
  • the OO model is good in general, do not listen to these who says it should be one utility method or class.

  • but I would expose only one class/interface- converter, no need to expose all classes (minutes,hours)

  • I would add Lamp model and BerlinClock or BerlinClockConverter model

  • I would not use static runner

  • I would rename getTime() - String time = BerlinClock.get("again string") - doesn't look clear.

    BerlinClock berlinClock = BerlinClock.createInstance("timesastring"); System.out.println (berlinClock.toString()); BerlinClock berlinClock = BerlinClock.createInstance("timesastring"); System.out.println (berlinClock.toString());

  • the OO model is good in general, do not listen to these who says it should be one utility method or class.

  • but I would expose only one class/interface- converter, no need to expose all classes (minutes,hours)

  • I would add Lamp model and BerlinClock or BerlinClockConverter model

  • I would not use static runner

  • I would rename getTime() - String time = BerlinClock.get("again string") - doesn't look clear.

    BerlinClock berlinClock = BerlinClock.createInstance("timesastring"); System.out.println (berlinClock.toString());

  • the OO model is good in general, do not listen to these who says it should be one utility method or class.

  • but I would expose only one class/interface- converter, no need to expose all classes (minutes,hours)

  • I would add Lamp model and BerlinClock or BerlinClockConverter model

  • I would not use static runner

  • I would rename getTime() - String time = BerlinClock.get("again string") - doesn't look clear.

    BerlinClock berlinClock = BerlinClock.createInstance("timesastring"); System.out.println (berlinClock.toString());

Source Link
magulla
  • 181
  • 1
  • 1
  • 7

  • the OO model is good in general, do not listen to these who says it should be one utility method or class.

  • but I would expose only one class/interface- converter, no need to expose all classes (minutes,hours)

  • I would add Lamp model and BerlinClock or BerlinClockConverter model

  • I would not use static runner

  • I would rename getTime() - String time = BerlinClock.get("again string") - doesn't look clear.

    BerlinClock berlinClock = BerlinClock.createInstance("timesastring"); System.out.println (berlinClock.toString());