Timeline for Foundation for 2D dungeon crawler game
Current License: CC BY-SA 3.0
10 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Mar 31, 2015 at 3:56 | answer | added | Loren Pechtel | timeline score: 5 | |
| Mar 31, 2015 at 1:31 | comment | added | nhgrif | @Sohcahtoa82 I highly recommend you post an answer. There is a lot to cover in this code. I didn't even scroll but maybe 1/4th of the way through the posted code before I posted my answer. There's plenty of other topics to make full answers out of, including the stuff you've mentioned in this comment. | |
| Mar 31, 2015 at 1:25 | comment | added | Sohcahtoa82 | My only comment (because nhgrif covered the class thing) would be that some of your functions don't have meaningful names, such as GameRules(), TurnOptions(), and TurnChoice(). Function names should almost always contain, and usually start with, a verb. I also disagree with putting spaces inside parentheses, but that's a personal style decision. For example, I'd rather do if (userChoice == 'y') rather than if( userChoice == 'y' ). To me, the line if( monsterinfo::monsterAmountDesired > ( fieldinfo::fieldLength - 2 ) * ( fieldinfo::fieldWidth - 2 ) - 9 ) becomes harder to read. | |
| Mar 31, 2015 at 0:32 | history | edited | Snizzlenose | CC BY-SA 3.0 | added 276 characters in body |
| Mar 31, 2015 at 0:02 | comment | added | Simon Forsberg | I am sorry, but I am downvoting because I find that you don't provide much explanation about what your game is about, compared to how much code you provide. I don't want you to create a bad habit of this, so I hope you will provide more explanation and context of your code in the future. | |
| Mar 30, 2015 at 23:47 | comment | added | nhgrif | Welcome to Code Review. This is a pretty good first post. I've posted an answer with some pointers, but my advice, if your primary goal is to really learn classes well, try to implement a RationalNumber class. It's a great way to actually learn what classes are and how they're supposed to be used. | |
| Mar 30, 2015 at 23:42 | answer | added | nhgrif | timeline score: 10 | |
| Mar 30, 2015 at 22:37 | comment | added | cha | You assigned probably involved a use of the class static members. For the real program however the classes fieldinfo or playerinfo with all static members are unnecessary. Global variables would do just fine. | |
| Mar 30, 2015 at 22:29 | review | First posts | |||
| Mar 30, 2015 at 22:49 | |||||
| Mar 30, 2015 at 22:26 | history | asked | Snizzlenose | CC BY-SA 3.0 |