Skip to main content
Computer Graphics

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

13
  • $\begingroup$ You shouldn't include the cosine foreshortening term in your brdf_pdf. $\endgroup$ Commented Jan 7, 2019 at 6:26
  • $\begingroup$ Im using cosine weighted hemispherical sampling so the BRDF PDF is supposed to be cos(theta)/pi $\endgroup$ Commented Jan 7, 2019 at 9:57
  • $\begingroup$ May be a coincidence but are your diffuse surfaces exactly PI times darker ? $\endgroup$ Commented Jan 11, 2019 at 7:38
  • $\begingroup$ @PaulHK - What would that imply? I don't think it's actually PI times darker, its just mis_weight times darker/brighter. Because as I said as soon as i remove mis_wieght and just divide by light_pdf I get the brighter image. $\endgroup$ Commented Jan 11, 2019 at 10:33
  • $\begingroup$ A shot in the dark really, I have seen other question on here were the solution was surprisingly that. $\endgroup$ Commented Jan 14, 2019 at 2:07