RPG movement holding down button

I don't know python, but have you tried setting a bool to true when the key is pressed, and changing the speed in an if statement based on that bool. When the key gets released you just have to set the bool back to false.

I don't know python or pygame, but assuming you're using a game library there should be a way to poll the state of the key, such as if it's currently down or not instead of if it was pressed since last update. Use that for checking and updating movement.

The next problem you will run into is it will update movement as fast as your logic update interval is as long as the key is held down. To fix this you need a variable to act as a cooldown so when you poll the state of the key and use it to move, the variable is set to the cooldown amount, and you can't move again until that cooldown reaches zero. So for an example of basic movement code assuming an arbitrary library and language:

constant int COOLDOWN_TIME = 170; //170 milliseconds int cooldown = 0; void update(int delta) { if (cooldown <= 0) { if (Input.isKeyDown(Key_Left)) { x -= x_speed; cooldown += COOLDOWN_TIME; } else if (Input.isKeyDown(Key_Right)) { x += x_speed; cooldown += COOLDOWN_TIME; } if (Input.isKeyDown(Key_Up)) { y -= y_speed; cooldown += COOLDOWN_TIME; } else if (Input.isKeyDown(Key_Down)) { y += y_speed cooldown += COOLDOWN_TIME; } } else { cooldown -= delta; } } 

Where delta would be the time in milliseconds passed since the last logic update.

I asked a question here that's very similar, and received the following answer:

The way to deal with this is to set a timer once the person taps the phone. The most user friendly scenario that you'd implement would look something like this:

1. When you detect a tap, set a timer (t = timeToRepeat)

2. On each frame, decrease the timer by dt

3. If the timer reaches zero, move the sprite a tile and reset the timer
4. If the user releases their finger before the first cycle of the timer, move the sprite one tile

Obviously the amount of time that you set your timer to will determine how fast your sprite moves. There are a few variations on this theme depending on the kind of behavior you want as well. For example, you can move the sprite once immediately upon detecting a tap and ignore step #4.

Implementing this would make the user able to tap to move a single time and to be able to move multiple tiles by holding, which I think is ideal.

I believe that this is what you were looking for:

keys = pygame.key.get_pressed() # checking pressed keys if keys[pygame.K_ESCAPE]: # If 'esc' - QUIT GAME game_exit = True if keys[pygame.K_RIGHT]: # If 'right' - MOVE RIGHT character.move('right') 

The longer you hold the key down, the more it would move

try to make a variable that holds up your movement results and then put the variable in the while loop not the for loop something like that

GameExit = True while not GameExit for event in pygame.event.get(): if event.type == pygame.QUIT: GameExit = True if event.type == pygame.KEYDOWN: if event.key == pygame.K_LEFT: x_change = -5 elif event.key == pygame.K_RIGHT: x_change = 5 if event.type == pygame.KEYUP: if event.key == pygame.K_LEFT or event.key == pygame.K_RIGHT: x_change = 0 x += x_change 

x is your object x place