Fix UnityGetProjectVersionV1 tests (#280)

* Update gitignore to exlude taskkey for testing * Do not build when running test * Add PR trigger

Author: FejZa

.github/workflows/build-test-deploy.yml

@@ -1,6 +1,8 @@
 name: Build, Test and Deploy
 
 on:
+ pull_request:
+ branches: [ main, development ]
  push:
  branches: [ main, development ]
 

.gitignore

@@ -105,4 +105,7 @@ dist
 
 *.js
 *.vsix
-.vs/
+.vs/
+
+# Azure DevOps extensions
+.taskkey

Tasks/UnityGetProjectVersion/UnityGetProjectVersionV1/package.json

@@ -5,7 +5,7 @@
  "main": "unity-get-project-version.js",
  "scripts": {
  "build": "tsc",
- "test": "npm run build && nyc mocha test/_suite.js",
+ "test": "nyc mocha test/_suite.js",
  "upload": "tfx build tasks upload --task-path ./",
  "dev-delete": "tfx build tasks delete --task-id 38ec98bf-601a-4390-9f2e-23d43dd6dbba",
  "dev-upload": "npm run build && npm run upload"

Tasks/UnityGetProjectVersion/UnityGetProjectVersionV1/test/_suite.ts

@@ -2,58 +2,70 @@ import assert from 'assert';
 import * as mocktest from 'azure-pipelines-task-lib/mock-test';
 import * as path from 'path';
 
-describe("Unity Get Project Version", async () => {
- it("Error determining the project version from file", async () => {
+describe("Unity Get Project Version", () => {
+ it("Error determining the project version from file", (done) => {
  let testPath = path.join(__dirname, 'errorDeterminingTheProjectVersionFromFile.js');
 
  let runner: mocktest.MockTestRunner = new mocktest.MockTestRunner(testPath);
 
- await runner.runAsync();
+ runner.runAsync()
+ .then(() => {
+ assert.strictEqual(runner.failed, true);
+ assert.strictEqual(runner.invokedToolCount, 0);
+ assert(runner.stdOutContained('loc_mock_failGetUnityEditorVersion | Unknown project version format encountered'));
 
- assert.strictEqual(runner.failed, true);
- assert.strictEqual(runner.invokedToolCount, 0);
- assert(runner.stdOutContained('loc_mock_failGetUnityEditorVersion | Unknown project version format encountered'));
+ done();
+ });
  })
 
- it("Success (alpha) determining the project version from file", async () => {
+ it("Success (alpha) determining the project version from file", (done) => {
  let testPath = path.join(__dirname, 'successAlphaDeterminingTheProjectVersionFromFile.js');
 
  let runner: mocktest.MockTestRunner = new mocktest.MockTestRunner(testPath);
 
- await runner.runAsync();
+ runner.runAsync()
+ .then(() => {
+ assert.strictEqual(runner.succeeded, true);
+ assert.strictEqual(runner.invokedToolCount, 0);
+ assert(runner.stdOutContained('loc_mock_successGetUnityEditorVersion 2022.3.49a1, revision=4dae1bb8668d, alpha=true, beta=false'));
+ assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersion;isOutput=false;issecret=false;]2022.3.49a1'));
+ assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersionRevision;isOutput=false;issecret=false;]4dae1bb8668d'));
 
- assert.strictEqual(runner.succeeded, true);
- assert.strictEqual(runner.invokedToolCount, 0);
- assert(runner.stdOutContained('loc_mock_successGetUnityEditorVersion 2022.3.49a1, revision=4dae1bb8668d, alpha=true, beta=false'));
- assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersion;isOutput=false;issecret=false;]2022.3.49a1'));
- assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersionRevision;isOutput=false;issecret=false;]4dae1bb8668d'));
+ done();
+ });
  })
 
- it("Success (beta) determining the project version from file", async () => {
+ it("Success (beta) determining the project version from file", (done) => {
  let testPath = path.join(__dirname, 'successBetaDeterminingTheProjectVersionFromFile.js');
 
  let runner: mocktest.MockTestRunner = new mocktest.MockTestRunner(testPath);
 
- await runner.runAsync();
+ runner.runAsync()
+ .then(() => {
+ assert.strictEqual(runner.succeeded, true);
+ assert.strictEqual(runner.invokedToolCount, 0);
+ assert(runner.stdOutContained('loc_mock_successGetUnityEditorVersion 2022.3.49b1, revision=4dae1bb8668d, alpha=false, beta=true'));
+ assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersion;isOutput=false;issecret=false;]2022.3.49b1'));
+ assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersionRevision;isOutput=false;issecret=false;]4dae1bb8668d'));
 
- assert.strictEqual(runner.succeeded, true);
- assert.strictEqual(runner.invokedToolCount, 0);
- assert(runner.stdOutContained('loc_mock_successGetUnityEditorVersion 2022.3.49b1, revision=4dae1bb8668d, alpha=false, beta=true'));
- assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersion;isOutput=false;issecret=false;]2022.3.49b1'));
- assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersionRevision;isOutput=false;issecret=false;]4dae1bb8668d'));
+ done();
+ });
  })
 
- it("Success (stable) determining the project version from file", async () => {
+ it("Success (stable) determining the project version from file", (done) => {
  let testPath = path.join(__dirname, 'successStableDeterminingTheProjectVersionFromFile.js');
 
  let runner: mocktest.MockTestRunner = new mocktest.MockTestRunner(testPath);
 
- await runner.runAsync();
+ runner.runAsync()
+ .then(() => {
+ assert.strictEqual(runner.succeeded, true);
+ assert.strictEqual(runner.invokedToolCount, 0);
+ assert(runner.stdOutContained('loc_mock_successGetUnityEditorVersion 2022.3.49f1, revision=4dae1bb8668d, alpha=false, beta=false'));
+ assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersion;isOutput=false;issecret=false;]2022.3.49f1'));
+ assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersionRevision;isOutput=false;issecret=false;]4dae1bb8668d'));
 
- assert.strictEqual(runner.succeeded, true);
- assert.strictEqual(runner.invokedToolCount, 0);
- assert(runner.stdOutContained('loc_mock_successGetUnityEditorVersion 2022.3.49f1, revision=4dae1bb8668d, alpha=false, beta=false'));
- assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersion;isOutput=false;issecret=false;]2022.3.49f1'));
- assert(runner.stdOutContained('##vso[task.setvariable variable=projectVersionRevision;isOutput=false;issecret=false;]4dae1bb8668d'));
+ done();
+ });
  })
 })