Remove unused endian operations

Add fast path to serialize_bits

Author: KredeGC

include/bitstream/stream/bit_reader.h

@@ -241,6 +241,19 @@ namespace bitstream
 
 BS_ASSERT(can_serialize_bits(num_bits));
 
+// Fast path
+if (num_bits == 32U && m_ScratchBits == 0U)
+{
+const uint32_t* ptr = m_Buffer + m_WordIndex;
+
+value = utility::to_big_endian32(*ptr);
+
+m_NumBitsRead += num_bits;
+m_WordIndex++;
+
+return true;
+}
+
 if (m_ScratchBits < num_bits)
 {
 const uint32_t* ptr = m_Buffer + m_WordIndex;

include/bitstream/stream/bit_writer.h

@@ -275,6 +275,19 @@ namespace bitstream
 
 BS_ASSERT(can_serialize_bits(num_bits));
 
+// Fast path
+if (num_bits == 32U && m_ScratchBits == 0U)
+{
+uint32_t* ptr = m_Buffer + m_WordIndex;
+
+*ptr = utility::to_big_endian32(value);
+
+m_NumBitsWritten += num_bits;
+m_WordIndex++;
+
+return true;
+}
+
 uint32_t offset = 64U - num_bits - m_ScratchBits;
 uint64_t ls_value = static_cast<uint64_t>(value) << offset;
 

include/bitstream/utility/endian.h

@@ -79,29 +79,6 @@ namespace bitstream::utility
 #endif // _WIN32 || __linux__
  }
 
- constexpr inline uint32_t endian_swap24(uint32_t value)
- {
- const uint32_t first = (value << 16) & 0x00FF0000;
- const uint32_t second = (value << 8) & 0x0000FF00;
- const uint32_t third = (value >> 16) & 0x000000FF;
-
- return first | second | third;
- }
-
- inline uint32_t endian_swap16(uint32_t value)
- {
-#if defined(_WIN32)
- return _byteswap_ushort(static_cast<uint16_t>(value));
-#elif defined(__linux__)
- return __builtin_bswap16(static_cast<uint16_t>(value));
-#else
- const uint32_t first = (value << 8) & 0x0000FF00;
- const uint32_t second = (value >> 8) & 0x000000FF;
-
- return first | second;
-#endif // _WIN32 || __linux__
- }
-
  inline uint32_t to_big_endian32(uint32_t value)
  {
  if constexpr (little_endian())

src/shared/test_types.h

@@ -1,6 +1,9 @@
 #pragma once
 
+#include <bitstream/stream/serialize_traits.h>
+
 #include <bitstream/utility/assert.h>
+#include <bitstream/utility/parameter.h>
 
 #include <cstddef>
 
@@ -19,11 +22,33 @@ namespace bitstream::test
  return values[index];
 }
 };
+
+ struct custom_type
+ {
+ bool enabled = true;
+ int count = 42;
+ };
 
  enum class test_enum
  {
  FirstValue = 3,
  SecondValue = 1,
  ThirdValue
  };
+}
+
+namespace bitstream
+{
+ template<>
+ struct serialize_traits<bitstream::test::custom_type>
+ {
+ template<typename Stream>
+ static bool serialize(Stream& stream, inout<Stream, bitstream::test::custom_type> value) noexcept
+ {
+ if (!stream.template serialize<bool>(value.enabled))
+ return false;
+
+ return stream.template serialize<int>(value.count);
+ }
+ };
 }