Skip to content

Commit be1ed58

Browse files
committed
Reuse isIncomplete.
Add -fno-limit-debug-info for debugging.
1 parent dbdab02 commit be1ed58

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/messages/text_document_completion.cc

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -177,12 +177,11 @@ void FilterAndSortCompletionResponse(
177177
for (size_t i = 0; i < items.size(); ++i)
178178
items[i].sortText = tofixedbase64(i, buf);
179179

180-
// FIXME
181-
// The trigger behivour of vscode is puzzling.
182-
// So maybe it's not feasible to cut out any results.
183-
// const size_t kMaxResultSize = 100u;
184-
// if (items.size() > kMaxResultSize)
185-
// items.resize(kMaxResultSize);
180+
const size_t kMaxResultSize = 100u;
181+
if (items.size() > kMaxResultSize) {
182+
items.resize(kMaxResultSize);
183+
complete_response->result.isIncomplete = true;
184+
}
186185
}
187186

188187
struct TextDocumentCompletionHandler : MessageHandler {

wscript

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,9 @@ def configure(ctx):
182182
if 'release' in ctx.options.variant:
183183
cxxflags.append('-O' if 'asan' in ctx.options.variant else '-O3')
184184

185+
if ctx.env.CXX_NAME == 'clang' and 'debug' in ctx.options.variant:
186+
cxxflags.append('-fno-limit-debug-info')
187+
185188
ctx.env.CXXFLAGS = cxxflags
186189
if not ctx.env.LDFLAGS:
187190
ctx.env.LDFLAGS = ldflags

0 commit comments

Comments
 (0)