NODE-318 collection.update error while setting a function with serializeFunctions option

Author: christkv

lib/collection.js

@@ -636,7 +636,7 @@ Collection.prototype.update = function(selector, document, options, callback) {
  // Do we return the actual result document
  // Either use override on the function, or go back to default on either the collection
  // level or db
- options['serializeFunctions'] = options['serializeFunctions'] || this.s.serializeFunctions;
+ finalOptions['serializeFunctions'] = options['serializeFunctions'] || this.s.serializeFunctions;
 
  // Execute the operation
  var op = {q: selector, u: document};

package.json

@@ -20,7 +20,7 @@
  , "readable-stream": "1.0.31"
  },
  "devDependencies": {
- "integra": "0.1.7"
+ "integra": "0.1.8"
  , "optimist": "0.6.1"
  , "bson": "~0.2"
  , "jsdoc": "3.3.0-alpha9"

test/functional/insert_tests.js

@@ -1781,6 +1781,35 @@ exports.shouldCorrectlyApplyBitOperator = {
  test.equal(1, doc.a);
  test.equal(0, doc.b);
 
+ db.close();
+ test.done();
+ });
+ });
+ });
+ });
+ }
+}
+
+exports.shouldCorrectlyPerformInsertAndUpdateWithFunctionSerialization = {
+ // Add a tag that our runner can trigger on
+ // in this case we are setting that node needs to be higher than 0.10.X to run
+ metadata: { requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] } },
+ 
+ // The actual test we wish to run
+ test: function(configuration, test) {
+ var db = configuration.newDbInstance(configuration.writeConcernMax(), {native_parser:false})
+ db.open(function(err, db) {
+ var col = db.collection('shouldCorrectlyPerformInsertAndUpdateWithFunctionSerialization', {serializeFunctions:true});
+ 
+ col.insert({a:1, f: function(x) {return x;}},function(err,doc){
+ test.equal(null,err);
+ 
+ col.update({a:1},{$set:{f: function(y){return y;}}},function(err,doc){
+ test.equal(null,err);
+
+ col.findOne({a:1}, function(err, doc) {
+ test.equal(null, err);
+ test.equal("function (y){return y;}", doc.f.code);
  db.close();
  test.done();
  });