Unify the format of wit files #641
Open
+840 −838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2025
sbc100 reviewed Jan 30, 2025
Member
sbc100 left a comment
sbc100 left a comment There was a problem hiding this comment.
IIUC these are mirrors of upstream files?
Would it make sense instead to apply these changes upstream first, to avoid have large downstream differences?
Contributor
| Thanks for this! These are just mirrors although I don't have an issue with normalizing what we have here while also updating upstream. For the individual proposal repos, we need to also have this run as a lint like we do with wit-abi-up action. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I wrote a tool that does project-level formatting: https://plugins.jetbrains.com/plugin/24001-wit-idl
Also respects the rules defined in the
.editorconfigfile.The current code style is a bit confusing.
Most file use a mixture of 2 and 4 spaces, some files use 6 spaces, and one uses 7 spaces.
This PR makes all wit files have a unified code style which defined in
.editorconfig.Changes will be synchronized to other upstreams later.
Projects with 0.3.0-draft wit still need some additional development work.