Skip to content

Commit 71e0ab7

Browse files
authored
Declared package side effects free
This sets the package.json field sideEffects to false. This allows for better tree shaking by downstream consumers, see https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free for more information. I skimmed over all included files and I did not see anything that would count following webpack's definition of tree shaking during a production build. There is one side effect, but I believe its only used in development builds, so it would be okay to tree shake: https://github.com/bvaughn/react-window/blob/master/src/createListComponent.js#L127-L136 For more details on how this field works and why it matter see the discussion here: react-dnd/react-dnd#1577
1 parent c43a2ee commit 71e0ab7

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
"main": "dist/index.cjs.js",
3838
"module": "dist/index.esm.js",
3939
"files": ["dist", "src/*.js"],
40+
"sideEffects": false,
4041
"scripts": {
4142
"flow": "flow check --max-warnings=0 src && flow check website",
4243
"precommit": "lint-staged",

0 commit comments

Comments
 (0)