Skip to content

Commit 925230f

Browse files
authored
Merge pull request #360 from benhowell/revert-358-master
Revert "export memoized version of Image"
2 parents 4797e19 + 45da083 commit 925230f

File tree

1 file changed

+2
-38
lines changed

1 file changed

+2
-38
lines changed

src/Image.tsx

Lines changed: 2 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,10 @@
1-
import { useState, MouseEvent, memo } from "react";
1+
import { useState, MouseEvent } from "react";
22
import { CheckButton } from "./CheckButton";
33
import { ImageExtended, ImageProps } from "./types";
44
import * as styles from "./styles";
55
import { getStyle } from "./styles";
66

7-
const imagePropsAreEqual = (prevProps: ImageProps, currProps: ImageProps) => {
8-
// states are the same iff the props are the same
9-
10-
const {
11-
item: prevItem,
12-
index: prevIndex,
13-
margin: prevMargin,
14-
height: prevHeight,
15-
isSelectable: prevIsSelectable,
16-
} = prevProps;
17-
18-
const {
19-
item: currItem,
20-
index: currIndex,
21-
margin: currMargin,
22-
height: currHeight,
23-
isSelectable: currIsSelectable,
24-
} = currProps;
25-
26-
return (
27-
prevItem.src === currItem.src &&
28-
prevItem.width === currItem.width &&
29-
prevItem.height === currItem.height &&
30-
prevItem.scaledHeight === currItem.scaledHeight &&
31-
prevItem.scaledWidth === currItem.scaledWidth &&
32-
prevItem.viewportWidth === currItem.viewportWidth &&
33-
prevItem.marginLeft === currItem.marginLeft &&
34-
prevIndex === currIndex &&
35-
prevMargin === currMargin &&
36-
prevHeight === currHeight &&
37-
prevIsSelectable === currIsSelectable
38-
);
39-
};
40-
41-
const ImageBase = <T extends ImageExtended>({
7+
export const Image = <T extends ImageExtended>({
428
item,
439
thumbnailImageComponent: ThumbnailImageComponent,
4410
isSelectable = true,
@@ -166,5 +132,3 @@ const ImageBase = <T extends ImageExtended>({
166132
</div>
167133
);
168134
};
169-
170-
export const Image = memo(ImageBase, imagePropsAreEqual);

0 commit comments

Comments
 (0)