2.12.24: «Direct use of $_REQUEST Superglobal detected»: mage2pro#30

Author: dmitrii-fediuk

Framework/Request.php

@@ -11,7 +11,7 @@ class Request {
  * @return array(string => mixed)|mixed|null
  */
 static function clean($k = null, $d = null) {return dfak(function() {return
-dfa_unset($_REQUEST, self::extraKeysRaw())
+dfa_unset(df_request(), self::extraKeysRaw())
 ;}, $k, $d);}
 
 /**
@@ -25,14 +25,14 @@ static function clean($k = null, $d = null) {return dfak(function() {return
 static function extra($k = null, $d = null) {return dfak(function() {return
 dfa_key_transform(function($k) {return
 df_trim_text_left($k, 'df-')
-;}, dfa_select($_REQUEST, self::extraKeysRaw()))
+;}, dfa_select(df_request(), self::extraKeysRaw()))
 ;}, $k, $d);}
 
 /**
  * 2017-01-01
  * @return array(string => mixed)
  */
 private static function extraKeysRaw() {return dfcf(function() {return array_filter(
-array_keys($_REQUEST), function($k) {return df_starts_with($k, 'df-');}
+array_keys(df_request()), function($k) {return df_starts_with($k, 'df-');}
 );});}
 }

Framework/lib/http.php

@@ -131,12 +131,16 @@ function df_http_json_c($urlBase, array $params = [], $timeout = null) {return d
  * @used-by df_store() 
  * @used-by \Df\Backend\Model\Auth::loginByEmail()
  * @used-by \Df\Framework\Plugin\Data\Form\Element\Fieldset::beforeAddField()
+ * @used-by \Df\Framework\Request::clean()
+ * @used-by \Df\Framework\Request::extra()
+ * @used-by \Df\Framework\Request::extraKeysRaw()
  * @used-by \Df\GoogleFont\Controller\Index\Index::execute()
  * @used-by \Df\GoogleFont\Controller\Index\Preview::familyA()
  * @used-by \Df\GoogleFont\Font\Variant\Preview\Params::fromRequest()
  * @used-by \Df\OAuth\App::getAndSaveTheRefreshToken()
  * @used-by \Df\OAuth\App::state()
  * @used-by \Df\OAuth\ReturnT::redirectUrl()
+ * @used-by \Df\Payment\CustomerReturn::execute()
  * @used-by \Df\Payment\CustomerReturn::isSuccess()
  * @used-by \Dfe\AllPay\Controller\CustomerReturn\Index::message()
  * @used-by \Dfe\AmazonLogin\Customer::url()

Payment/CustomerReturn.php

@@ -35,7 +35,7 @@ class CustomerReturn extends Action {
  */
 function execute() {
 if ($this->needLog()) {
-dfp_report($this->m(), $_REQUEST, 'customerReturn');
+dfp_report($this->m(), df_request(), 'customerReturn');
 }
 $ss = df_checkout_session(); /** @var Session $ss */
 /** @var O|DFO|null $o */ /** @var Redirect $result */

composer.json

@@ -1,6 +1,6 @@
 {
 "name": "mage2pro/core"
-,"version": "2.12.23"
+,"version": "2.12.24"
 ,"description": "Mage2.PRO core package."
 ,"type": "magento2-module"
 ,"homepage": "https://mage2.pro"