fix(immutable-data): ignoreAccessorPattern can now handle NonNullExpressions and ChainExpressions (#849)

fix #840

Author: RebeccaStevens

src/utils/misc.ts

@@ -7,13 +7,15 @@ import {
  hasID,
  hasKey,
  isAssignmentExpression,
+ isChainExpression,
  isDefined,
  isIdentifier,
  isMemberExpression,
  isPrivateIdentifier,
- isThisExpression,
  isTSAsExpression,
+ isTSNonNullExpression,
  isTSTypeAnnotation,
+ isThisExpression,
  isUnaryExpression,
  isVariableDeclaration,
 } from "#/utils/type-guards";
@@ -73,7 +75,9 @@ function getNodeIdentifierText(
  ? context.sourceCode
  .getText(node.typeAnnotation as TSESTree.Node)
  .replaceAll(/\s+/gmu, "")
- : isTSAsExpression(node)
+ : isTSAsExpression(node) ||
+ isTSNonNullExpression(node) ||
+ isChainExpression(node)
  ? getNodeIdentifierText(node.expression, context)
  : null;
 

src/utils/type-guards.ts

@@ -75,6 +75,12 @@ export function isCallExpression(
  return node.type === AST_NODE_TYPES.CallExpression;
 }
 
+export function isChainExpression(
+ node: TSESTree.Node,
+): node is TSESTree.ChainExpression {
+ return node.type === AST_NODE_TYPES.ChainExpression;
+}
+
 export function isPropertyDefinition(
  node: TSESTree.Node,
 ): node is TSESTree.PropertyDefinition {
@@ -303,6 +309,12 @@ export function isTSInterfaceHeritage(
  return node.type === AST_NODE_TYPES.TSInterfaceHeritage;
 }
 
+export function isTSNonNullExpression(
+ node: TSESTree.Node,
+): node is TSESTree.TSNonNullExpression {
+ return node.type === AST_NODE_TYPES.TSNonNullExpression;
+}
+
 export function isTSNullKeyword(
  node: TSESTree.Node,
 ): node is TSESTree.TSNullKeyword {

tests/rules/immutable-data/ts/object/valid.ts

@@ -282,6 +282,12 @@ const tests: Array<ValidTestCaseSet<OptionsOf<typeof rule>>> = [
  `,
  optionsSet: [[{ ignoreAccessorPattern: "mutable*.*" }]],
  },
+ {
+ code: dedent`
+ mutable_foo!.baz = "hello world";
+ `,
+ optionsSet: [[{ ignoreAccessorPattern: "mutable*.*" }]],
+ },
 ];
 
 export default tests;