integration test incorrect interpreter behavior (#1737)

Summary: interpreter fails to update type errors when changing from a bad one to a good one reported here #1632 Differential Revision: D87664939

Author: kinto0

pyrefly/lib/test/lsp/lsp_interaction/configuration.rs

@@ -278,6 +278,97 @@ fn test_workspace_pythonpath_ignored_when_set_in_config_file() {
  interaction.shutdown().expect("Failed to shutdown");
 }
 
+// Only run this test on unix since windows has no way to mock a .exe without compiling something
+// (we call python with python.exe)
+#[cfg(unix)]
+#[test]
+fn test_interpreter_change_removes_type_errors() {
+ let test_files_root = get_test_files_root();
+ let good_interpreter_path =
+ setup_dummy_interpreter(&test_files_root.path().join("custom_interpreter"));
+ let bad_interpreter_path = setup_dummy_interpreter(
+ &test_files_root
+ .path()
+ .join("interpreter_with_no_site_packages"),
+ );
+
+ let mut interaction = LspInteraction::new();
+ interaction.set_root(test_files_root.path().to_path_buf());
+ interaction
+ .initialize(InitializeSettings {
+ configuration: Some(Some(
+ json!([{"pyrefly": {"displayTypeErrors": "force-on"}}]),
+ )),
+ ..Default::default()
+ })
+ .unwrap();
+
+ interaction.client.did_open("custom_interpreter/src/foo.py");
+ // Without any interpreter configured, there should be 1 import error
+ interaction
+ .client
+ .expect_publish_diagnostics_error_count(
+ test_files_root.path().join("custom_interpreter/src/foo.py"),
+ 1,
+ )
+ .unwrap();
+ // Configure broken interpreter with empty site-packages - should still have 1 import error
+ interaction.client.did_change_configuration();
+ interaction
+ .client
+ .expect_request::<WorkspaceConfiguration>(json!({"items":[{"section":"python"}]}))
+ .unwrap()
+ .send_configuration_response(json!([
+ {
+ "pythonPath": bad_interpreter_path.to_str().unwrap()
+ }
+ ]));
+ interaction
+ .client
+ .expect_publish_diagnostics_error_count(
+ test_files_root.path().join("custom_interpreter/src/foo.py"),
+ 1,
+ )
+ .unwrap();
+
+ // Switch to good interpreter with site-packages
+ interaction.client.did_change_configuration();
+ interaction
+ .client
+ .expect_request::<WorkspaceConfiguration>(json!({"items":[{"section":"python"}]}))
+ .unwrap()
+ .send_configuration_response(json!([
+ {
+ "pythonPath": good_interpreter_path.to_str().unwrap()
+ }
+ ]));
+
+ // BUG: Expecting 1 error demonstrates incorrect behavior.
+ // After switching to good interpreter, the error should be resolved to 0.
+ interaction
+ .client
+ .expect_publish_diagnostics_error_count(
+ test_files_root.path().join("custom_interpreter/src/foo.py"),
+ 1,
+ )
+ .unwrap();
+
+ // BUG: it works after a did_close -> did_open
+ interaction
+ .client
+ .did_close("custom_interpreter/src/foo.py");
+ interaction.client.did_open("custom_interpreter/src/foo.py");
+ interaction
+ .client
+ .expect_publish_diagnostics_error_count(
+ test_files_root.path().join("custom_interpreter/src/foo.py"),
+ 0,
+ )
+ .unwrap();
+
+ interaction.shutdown().unwrap();
+}
+
 #[test]
 fn test_disable_language_services() {
  let test_files_root = get_test_files_root();

pyrefly/lib/test/lsp/lsp_interaction/object_model.rs

@@ -37,6 +37,7 @@ use lsp_types::notification::DidChangeNotebookDocument;
 use lsp_types::notification::DidChangeTextDocument;
 use lsp_types::notification::DidChangeWatchedFiles;
 use lsp_types::notification::DidCloseNotebookDocument;
+use lsp_types::notification::DidCloseTextDocument;
 use lsp_types::notification::DidOpenNotebookDocument;
 use lsp_types::notification::DidOpenTextDocument;
 use lsp_types::notification::Exit;
@@ -451,6 +452,18 @@ impl TestClient {
  }))
  }
 
+ pub fn did_close(&self, file: &'static str) {
+ let path = self.get_root_or_panic().join(file);
+ self.send_notification::<DidCloseTextDocument>(json!({
+ "textDocument": {
+ "uri": Url::from_file_path(&path).unwrap().to_string(),
+ "languageId": "python",
+ "version": 1,
+ "text": read_to_string(&path).unwrap(),
+ },
+ }));
+ }
+
  pub fn did_open(&self, file: &'static str) {
  let path = self.get_root_or_panic().join(file);
  self.send_notification::<DidOpenTextDocument>(json!({

pyrefly/lib/test/lsp/lsp_interaction/test_files/interpreter_with_no_site_packages/bin/python

@@ -0,0 +1,9 @@
+#!/bin/bash
+if [[ "$1" == "-c" && "$2" == *"import json, sys"* ]]; then
+ cat << 'EOF'
+{"python_platform": "linux", "python_version": "3.12.0", "site_package_path": []}
+EOF
+else
+ echo "Mock python interpreter - args:" "$@" >&2
+ exit 1
+fi