[v3] Add option 'persistence' and make setPersistence internal #232
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
setPersistencehas to be called before any database references have been created. Since the database constructor immediately creates refs to.info/serverTimeOffset, callingsetPersistencewill always throw and it is not possible to enable persistence currently. Furthermore,setPersistenceis not part of the Web SDK API anyway.To fix this issue #216, this PR makes
setPersistenceinternal and adds instead an option persistence that can be supplied to the Firestack constructor. This guarantees that persistence will be enabled before any refs are created. The default value is false.