Skip to content

[v3] Always return from 'push' with callback / promise #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v3] Always return from 'push' with callback / promise #234

wants to merge 1 commit into from

Conversation

@moooji
Copy link

@moooji moooji commented Jan 11, 2017

No description provided.

@moooji moooji mentioned this pull request Jan 11, 2017
Closed
@moooji moooji changed the title Always return from 'push' with callback / promise [v3] Always return from 'push' with callback / promise Jan 11, 2017
@Salakar
Copy link
Collaborator

Salakar commented Jan 11, 2017 •
edited
Loading

This is incorrect, see https://firebase.google.com/docs/reference/js/firebase.database.Reference#push

Push without a value returns a reference, push with a value returns a promise.
@moooji
Copy link
Author

moooji commented Jan 11, 2017

Ok, no problem. If the Web SDK says so then it's fine like it is I guess. :) This issue can be closed then I think #231
@moooji moooji closed this Jan 11, 2017
@Salakar
Copy link
Collaborator

Salakar commented Jan 12, 2017

Thanks though =]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@moooji @Salakar