Do not encode UNSET values in struct arrays. #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
CharString suggested changes Nov 11, 2025
Comment on lines +4064 to +4074
| def test_unset_encode_struct_array_like(self, proto): | ||
| class Ex(Struct, array_like=True): | ||
| x: Union[int, UnsetType] = UNSET | ||
| y: Union[int, UnsetType] = UNSET | ||
| z: int = 0 | ||
| | ||
| for x, y in [(Ex(), [0]), (Ex(x=1), [1, 0]), (Ex(y=2), [2, 0])]: | ||
| res = proto.encode(x) | ||
| sol = proto.encode(y) | ||
| assert res == sol | ||
| |
There was a problem hiding this comment.
We need another assertion here:
roundtrip = proto.decode(res, type=Ex) assert roundtrip == resAnd add a z case for good measure.
What good is it to speak, if we will be misunderstood?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #723