- Notifications
You must be signed in to change notification settings - Fork 15.3k
[AMDGPU] Avoid undefs in hazard-gfx1250-flat-scr-hi.mir. NFC #170396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rampitec wants to merge 1 commit into users/rampitec/handle-physreg-in-flat-scr-hi-check Choose a base branch from users/rampitec/avoid-undef-in-hazard-gfx1250-flat-scr-hi.mir
base: users/rampitec/handle-physreg-in-flat-scr-hi-check
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[AMDGPU] Avoid undefs in hazard-gfx1250-flat-scr-hi.mir. NFC #170396
rampitec wants to merge 1 commit into users/rampitec/handle-physreg-in-flat-scr-hi-check from users/rampitec/avoid-undef-in-hazard-gfx1250-flat-scr-hi.mir
+54 −30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator Author
This stack of pull requests is managed by sgh. |
Member
| @llvm/pr-subscribers-backend-amdgpu Author: Stanislav Mekhanoshin (rampitec) ChangesFull diff: https://github.com/llvm/llvm-project/pull/170396.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/AMDGPU/hazard-gfx1250-flat-scr-hi.mir b/llvm/test/CodeGen/AMDGPU/hazard-gfx1250-flat-scr-hi.mir index e3b28c5518695..5dafa1b72ed10 100644 --- a/llvm/test/CodeGen/AMDGPU/hazard-gfx1250-flat-scr-hi.mir +++ b/llvm/test/CodeGen/AMDGPU/hazard-gfx1250-flat-scr-hi.mir @@ -8,10 +8,12 @@ body: | bb.0: ; GCN-LABEL: name: s_ashr_i64 - ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi - ; GCN-NEXT: [[S_ASHR_I64_:%[0-9]+]]:sreg_64 = S_ASHR_I64 undef %2:sreg_64, [[COPY]], implicit-def $scc + ; GCN: [[DEF:%[0-9]+]]:sreg_64 = IMPLICIT_DEF + ; GCN-NEXT: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_ASHR_I64_:%[0-9]+]]:sreg_64 = S_ASHR_I64 [[DEF]], [[COPY]], implicit-def $scc + %1:sreg_64 = IMPLICIT_DEF %0:sreg_32 = COPY $src_flat_scratch_base_hi - %2:sreg_64 = S_ASHR_I64 undef %1:sreg_64, %0, implicit-def $scc + %2:sreg_64 = S_ASHR_I64 %1:sreg_64, %0, implicit-def $scc ... --- @@ -21,10 +23,12 @@ body: | bb.0: ; GCN-LABEL: name: s_lshl_b64 - ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi - ; GCN-NEXT: [[S_LSHL_B64_:%[0-9]+]]:sreg_64 = S_LSHL_B64 undef %2:sreg_64, [[COPY]], implicit-def $scc + ; GCN: [[DEF:%[0-9]+]]:sreg_64 = IMPLICIT_DEF + ; GCN-NEXT: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_LSHL_B64_:%[0-9]+]]:sreg_64 = S_LSHL_B64 [[DEF]], [[COPY]], implicit-def $scc + %1:sreg_64 = IMPLICIT_DEF %0:sreg_32 = COPY $src_flat_scratch_base_hi - %2:sreg_64 = S_LSHL_B64 undef %1:sreg_64, %0, implicit-def $scc + %2:sreg_64 = S_LSHL_B64 %1:sreg_64, %0, implicit-def $scc ... --- @@ -34,10 +38,12 @@ body: | bb.0: ; GCN-LABEL: name: s_lshr_b64 - ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi - ; GCN-NEXT: [[S_LSHR_B64_:%[0-9]+]]:sreg_64 = S_LSHR_B64 undef %2:sreg_64, [[COPY]], implicit-def $scc + ; GCN: [[DEF:%[0-9]+]]:sreg_64 = IMPLICIT_DEF + ; GCN-NEXT: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_LSHR_B64_:%[0-9]+]]:sreg_64 = S_LSHR_B64 [[DEF]], [[COPY]], implicit-def $scc + %1:sreg_64 = IMPLICIT_DEF %0:sreg_32 = COPY $src_flat_scratch_base_hi - %2:sreg_64 = S_LSHR_B64 undef %1:sreg_64, %0, implicit-def $scc + %2:sreg_64 = S_LSHR_B64 %1:sreg_64, %0, implicit-def $scc ... --- @@ -47,10 +53,12 @@ body: | bb.0: ; GCN-LABEL: name: s_bfe_i64 - ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi - ; GCN-NEXT: [[S_BFE_I64_:%[0-9]+]]:sreg_64 = S_BFE_I64 undef %2:sreg_64, [[COPY]], implicit-def $scc + ; GCN: [[DEF:%[0-9]+]]:sreg_64 = IMPLICIT_DEF + ; GCN-NEXT: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_BFE_I64_:%[0-9]+]]:sreg_64 = S_BFE_I64 [[DEF]], [[COPY]], implicit-def $scc + %1:sreg_64 = IMPLICIT_DEF %0:sreg_32 = COPY $src_flat_scratch_base_hi - %2:sreg_64 = S_BFE_I64 undef %1:sreg_64, %0, implicit-def $scc + %2:sreg_64 = S_BFE_I64 %1:sreg_64, %0, implicit-def $scc ... --- @@ -60,10 +68,12 @@ body: | bb.0: ; GCN-LABEL: name: s_bfe_u64 - ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi - ; GCN-NEXT: [[S_BFE_U64_:%[0-9]+]]:sreg_64 = S_BFE_U64 undef %2:sreg_64, [[COPY]], implicit-def $scc + ; GCN: [[DEF:%[0-9]+]]:sreg_64 = IMPLICIT_DEF + ; GCN-NEXT: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[S_BFE_U64_:%[0-9]+]]:sreg_64 = S_BFE_U64 [[DEF]], [[COPY]], implicit-def $scc + %1:sreg_64 = IMPLICIT_DEF %0:sreg_32 = COPY $src_flat_scratch_base_hi - %2:sreg_64 = S_BFE_U64 undef %1:sreg_64, %0, implicit-def $scc + %2:sreg_64 = S_BFE_U64 %1:sreg_64, %0, implicit-def $scc ... --- @@ -86,10 +96,14 @@ body: | bb.0: ; GCN-LABEL: name: s_bitcmp0_b64 - ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi - ; GCN-NEXT: S_BITCMP0_B64 undef %1:sreg_64, [[COPY]], implicit undef $scc, implicit-def $scc + ; GCN: [[DEF:%[0-9]+]]:sreg_64 = IMPLICIT_DEF + ; GCN-NEXT: $scc = IMPLICIT_DEF + ; GCN-NEXT: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: S_BITCMP0_B64 [[DEF]], [[COPY]], implicit $scc, implicit-def $scc + %1:sreg_64 = IMPLICIT_DEF + $scc = IMPLICIT_DEF %0:sreg_32 = COPY $src_flat_scratch_base_hi - S_BITCMP0_B64 undef %1:sreg_64, %0, implicit undef $scc, implicit-def $scc + S_BITCMP0_B64 %1:sreg_64, %0, implicit $scc, implicit-def $scc ... --- @@ -99,10 +113,14 @@ body: | bb.0: ; GCN-LABEL: name: s_bitcmp1_b64 - ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi - ; GCN-NEXT: S_BITCMP1_B64 undef %1:sreg_64, [[COPY]], implicit undef $scc, implicit-def $scc + ; GCN: [[DEF:%[0-9]+]]:sreg_64 = IMPLICIT_DEF + ; GCN-NEXT: $scc = IMPLICIT_DEF + ; GCN-NEXT: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: S_BITCMP1_B64 [[DEF]], [[COPY]], implicit $scc, implicit-def $scc + %1:sreg_64 = IMPLICIT_DEF + $scc = IMPLICIT_DEF %0:sreg_32 = COPY $src_flat_scratch_base_hi - S_BITCMP1_B64 undef %1:sreg_64, %0, implicit undef $scc, implicit-def $scc + S_BITCMP1_B64 %1:sreg_64, %0, implicit $scc, implicit-def $scc ... --- @@ -125,10 +143,12 @@ body: | bb.0: ; GCN-LABEL: name: s_bitset0_b64 - ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi - ; GCN-NEXT: [[S_BITSET0_B64_:%[0-9]+]]:sreg_64 = S_BITSET0_B64 [[COPY]], undef [[S_BITSET0_B64_]], implicit-def $scc + ; GCN: [[DEF:%[0-9]+]]:sreg_64 = IMPLICIT_DEF + ; GCN-NEXT: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[DEF:%[0-9]+]]:sreg_64 = S_BITSET0_B64 [[COPY]], [[DEF]], implicit-def $scc + %1:sreg_64 = IMPLICIT_DEF %0:sreg_32 = COPY $src_flat_scratch_base_hi - %1:sreg_64 = S_BITSET0_B64 %0, undef %1:sreg_64, implicit-def $scc + %1:sreg_64 = S_BITSET0_B64 %0, %1:sreg_64, implicit-def $scc ... --- @@ -138,10 +158,12 @@ body: | bb.0: ; GCN-LABEL: name: s_bitset1_b64 - ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi - ; GCN-NEXT: [[S_BITSET1_B64_:%[0-9]+]]:sreg_64 = S_BITSET1_B64 [[COPY]], undef [[S_BITSET1_B64_]], implicit-def $scc + ; GCN: [[DEF:%[0-9]+]]:sreg_64 = IMPLICIT_DEF + ; GCN-NEXT: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: [[DEF:%[0-9]+]]:sreg_64 = S_BITSET1_B64 [[COPY]], [[DEF]], implicit-def $scc + %1:sreg_64 = IMPLICIT_DEF %0:sreg_32 = COPY $src_flat_scratch_base_hi - %1:sreg_64 = S_BITSET1_B64 %0, undef %1:sreg_64, implicit-def $scc + %1:sreg_64 = S_BITSET1_B64 %0, %1:sreg_64, implicit-def $scc ... --- @@ -151,8 +173,10 @@ body: | bb.0: ; GCN-LABEL: name: s_ashr_i64_phys_dst - ; GCN: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi - ; GCN-NEXT: $sgpr0_sgpr1 = S_ASHR_I64 undef %1:sreg_64, [[COPY]], implicit-def $scc + ; GCN: [[DEF:%[0-9]+]]:sreg_64 = IMPLICIT_DEF + ; GCN-NEXT: [[COPY:%[0-9]+]]:sreg_32 = COPY $src_flat_scratch_base_hi + ; GCN-NEXT: $sgpr0_sgpr1 = S_ASHR_I64 [[DEF]], [[COPY]], implicit-def $scc + %1:sreg_64 = IMPLICIT_DEF %0:sreg_32 = COPY $src_flat_scratch_base_hi - $sgpr0_sgpr1 = S_ASHR_I64 undef %1:sreg_64, %0, implicit-def $scc + $sgpr0_sgpr1 = S_ASHR_I64 %1:sreg_64, %0, implicit-def $scc ... |
arsenm approved these changes Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.