Skip to content

Conversation

@rijenkii
Copy link
Contributor

@rijenkii rijenkii commented Mar 3, 2025

Fixes #260.
Fixes #267.

Replaces

using _guard = this.enteringGuard(); // Function body

in Encoder and Decoder classes with

try { this.entered = true; // Function body } finally { this.entered = false; }

Diff is ugly, but no other changes have been made.
Recommend disabling whitespace changes when reviewing, then only actual code changes are visible.

All tests pass.

@rijenkii
Copy link
Contributor Author

rijenkii commented Mar 5, 2025

Alternative, perhaps better solution if using shiny new things is a must (completely understand, I am the same), see #270.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.14286% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.36%. Comparing base (59057ee) to head (69295b3).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/Decoder.ts 96.55% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@ ## main #268 +/- ## ========================================== + Coverage 97.28% 97.36% +0.08%  ========================================== Files 17 16 -1 Lines 1140 1138 -2 Branches 253 252 -1 ========================================== - Hits 1109 1108 -1  + Misses 31 30 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@gfx
Copy link
Member

gfx commented Mar 11, 2025

Thanks for your contribution. Looks good to me. Will release a new version soon.

@gfx
Copy link
Member

gfx commented Mar 12, 2025

close #270

@gfx gfx merged commit 8b943e3 into msgpack:main Mar 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants