Skip to content

Conversation

@stefan-niedermann
Copy link
Member

@stefan-niedermann stefan-niedermann commented Jun 23, 2021

Fix #1277

image

Signed-off-by: Stefan Niedermann <info@niedermann.it>
Signed-off-by: Stefan Niedermann <info@niedermann.it>
@korelstar
Copy link
Member

I like it, but I'm unsure if "save" is the correct wording. Maybe "OK" is better?

According to the Material Design Guidelines, I would understand this dialog as confirmation dialog, which should have buttons Cancel and OK.
https://material.io/components/dialogs#confirmation-dialog

@stefan-niedermann
Copy link
Member Author

stefan-niedermann commented Jun 24, 2021

I am not yet sure how i want to implement it - either save implicitly, just like the notes itself, or explicitly using a button (as it is at the moment). By the way the favorite state is saved directly, regardless of the buttom you choose - it felt unnatural to only save it after pressing a button...

From various people i learned that the primary button should be a verb rather than just "ok", so the user is more aware of the actual action 🤷‍♂️ but that's just wording, still have some bigger issues / troubles to be solved 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants