Skip to content

Commit 6896c0d

Browse files
authored
remove nodejs8Action (apache#176)
NodeJS 8 End-Of-Life was Dec 31, 2019.
1 parent d263605 commit 6896c0d

18 files changed

+73
-502
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ deploy:
4242
all_branches: true
4343
repo: apache/openwhisk-runtime-nodejs
4444
- provider: script
45-
script: "./tools/travis/publish.sh openwhisk nodejs8Action nightly && ./tools/travis/publish.sh openwhisk nodejs10Action nightly && ./tools/travis/publish.sh openwhisk nodejs12Action nightly && ./tools/travis/publish.sh openwhisk nodejs14Action nightly && ./tools/travis/publish.sh openwhisk typescript37Action nightly"
45+
script: "./tools/travis/publish.sh openwhisk nodejs10Action nightly && ./tools/travis/publish.sh openwhisk nodejs12Action nightly && ./tools/travis/publish.sh openwhisk nodejs14Action nightly && ./tools/travis/publish.sh openwhisk typescript37Action nightly"
4646
on:
4747
branch: master
4848
repo: apache/openwhisk-runtime-nodejs

README.md

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ This repository contains sources files needed to build the Node.js runtimes for
2626

2727
The following Node.js runtime versions (with kind & image labels) are generated by the build system:
2828

29-
- Node.js 8.16.1 (`nodejs:8` & `openwhisk/action-nodejs-v8`)
3029
- Node.js 10.16.3 (`nodejs:10` & `openwhisk/action-nodejs-v10`)
3130
- Node.js 12.8.1 (`nodejs:12` & `openwhisk/action-nodejs-v12`)
3231
- Node.js 14.2.0 (`nodejs:14` & `openwhisk/action-nodejs-v14`)
@@ -39,12 +38,6 @@ This README documents the build, customisation and testing of these runtime imag
3938

4039
If the deployment of Apache OpenWhisk includes these images in the runtime manifest, use the `--kind` parameter to select the Node.js runtime version.
4140

42-
### Node.js v8
43-
44-
```
45-
wsk action update myAction myAction.js --kind nodejs:8
46-
```
47-
4841
### Node.js v10
4942

5043
```
@@ -67,7 +60,6 @@ wsk action update myAction myAction.js --kind nodejs:14
6760

6861
All the runtime images are published by the project to Docker Hub @ [https://hub.docker.com/u/openwhisk](https://hub.docker.com/u/openwhisk)
6962

70-
- [https://hub.docker.com/r/openwhisk/action-nodejs-v8](https://hub.docker.com/r/openwhisk/action-nodejs-v8)
7163
- [https://hub.docker.com/r/openwhisk/action-nodejs-v10](https://hub.docker.com/r/openwhisk/action-nodejs-v10)
7264
- [https://hub.docker.com/r/openwhisk/action-nodejs-v12](https://hub.docker.com/r/openwhisk/action-nodejs-v12)
7365
- [https://hub.docker.com/r/openwhisk/action-nodejs-v14](https://hub.docker.com/r/openwhisk/action-nodejs-v14)
@@ -97,13 +89,12 @@ The `core/nodejsActionBase` folder contains the Node.js app server used to imple
9789
- Run the `distDocker` command to generate local Docker images for the different runtime versions.
9890

9991
```
100-
./gradlew core:nodejs8Action:distDocker
10192
./gradlew core:nodejs10Action:distDocker
10293
./gradlew core:nodejs12Action:distDocker
10394
./gradlew core:nodejs14Action:distDocker
10495
```
10596

106-
This will return the following runtime images with the following names: `action-nodejs-v8`, `action-nodejs-v10`, `action-nodejs-v12` and `action-nodejs-v14`.
97+
This will return the following runtime images with the following names: `action-nodejs-v10`, `action-nodejs-v12` and `action-nodejs-v14`.
10798

10899
### Testing
109100

@@ -119,7 +110,6 @@ This will return the following runtime images with the following names: `action-
119110
- Build the custom Docker images used in local testing.
120111

121112
```
122-
./gradlew tests:dat:docker:nodejs8docker:distDocker
123113
./gradlew tests:dat:docker:nodejs10docker:distDocker
124114
./gradlew tests:dat:docker:nodejs12docker:distDocker
125115
./gradlew tests:dat:docker:nodejs14docker:distDocker

core/nodejs8Action/.dockerignore

Lines changed: 0 additions & 13 deletions
This file was deleted.

core/nodejs8Action/CHANGELOG.md

Lines changed: 0 additions & 136 deletions
This file was deleted.

core/nodejs8Action/Dockerfile

Lines changed: 0 additions & 43 deletions
This file was deleted.

core/nodejs8Action/build.gradle

Lines changed: 0 additions & 86 deletions
This file was deleted.

core/nodejs8Action/knative/Dockerfile

Lines changed: 0 additions & 37 deletions
This file was deleted.

settings.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,10 @@
1818
include 'tests'
1919

2020
include 'core:nodejsActionBase'
21-
include 'core:nodejs8Action'
2221
include 'core:nodejs10Action'
2322
include 'core:nodejs12Action'
2423
include 'core:nodejs14Action'
2524
include 'core:typescript37Action'
26-
include 'tests:dat:docker:nodejs8docker'
2725
include 'tests:dat:docker:nodejs10docker'
2826
include 'tests:dat:docker:nodejs12docker'
2927
include 'tests:dat:docker:nodejs14docker'

0 commit comments

Comments
 (0)