Skip to content

No unsafe #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

No unsafe #1646

wants to merge 9 commits into from
+150 −163

Conversation

@Sk7Str1p3
Copy link
Contributor

@Sk7Str1p3 Sk7Str1p3 commented Nov 27, 2025

We all love rust for its safety and soundness. Until now, onefetch-image had few unsafe blocks, and i fixed that.
@Sk7Str1p3
Copy link
Contributor Author

Sk7Str1p3 commented Nov 27, 2025 •
edited
Loading

@spenserblack please review my get_dimensions reimpl. I'm not sure it will work how it's intended and not even sure if I really needed to rewrite it nevermind, found safe implementation in rustix
@o2sh o2sh self-requested a review December 1, 2025 22:08
@o2sh
Copy link
Owner

o2sh commented Dec 1, 2025

Thanks @Sk7Str1p3, I will test it on a few terminals and report back.
@Sk7Str1p3
Copy link
Contributor Author

Sk7Str1p3 commented Dec 2, 2025

Alright. I already tested it with kitty and foot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Sk7Str1p3 @o2sh @spenserblack