Allow error objects; Send error codes if upload failed

Author: simonwep

src/api/api.js

@@ -12,12 +12,6 @@ const mapHandler = mod => async (req, res) => {
  const response = await mod(req, res).then(res => {
  return {data: res, error: null};
  }).catch(reason => {
-
- if (typeof reason !== 'string') {
- console.warn('Suspicious error', reason); // eslint-disable-line no-console
- reason = 'Internal error.';
- }
-
  return {data: null, error: reason};
  });
 

src/api/endpoints/data/upload/upload.js

@@ -15,20 +15,20 @@ module.exports = async req => {
  fs.unlink(path, () => 0);
  }
 
- throw reason;
+ throw {code: -1, text: reason};
  });
 
  const contentLength = Number(req.get('content-length'));
 
  // Validate header
  if (isNaN(contentLength)) {
- throw 'Invalid content-length header';
+ throw {code: 1, text: 'Invalid content-length header'};
  }
 
  // Compare current storage size and upload size with limit
  const {totalStorageLimitPerUser} = _config.server;
  if (~totalStorageLimitPerUser && (await usedSpaceBy(user.id)) + contentLength > totalStorageLimitPerUser) {
- throw `Storage limit of ${totalStorageLimitPerUser} bytes exceed`;
+ throw {code: 2, text: `Storage limit of ${totalStorageLimitPerUser} bytes exceed`};
  }
 
  // Rename files and create nodes
@@ -45,14 +45,14 @@ module.exports = async req => {
  const parent = fieldname.substring(0, fieldname.indexOf('-'));
  if (!parent) {
  fs.unlinkSync(path);
- throw 'Invalid node key';
+ throw {code: 10, text: 'Invalid node key'};
  }
 
  // Check if destination exists and is a folder
  const destNode = await nodeModel.findOne({owner: user.id, id: parent}).exec();
  if (!destNode || destNode.type !== 'dir') {
  fs.unlinkSync(path);
- throw 'Invalid parent node';
+ throw {code: 11, text: 'Invalid parent node'};
  }
 
  // Create and push new node