merge(#3): from richardneililagan/master

Fixes: [rel=noreferrer] is not added when element has no existing [rel]

Author: SukkaW

package-lock.json

@@ -28,19 +28,19 @@ export function posthtmlExternalLink(
  }
  }
 
- if (node.attrs.rel) {
-  const rels = new Set(node.attrs.rel.split(/\s+/));
-  rels.add('noopener');
- rels.add('nofollow');
- rels.add('external');
- if (config.noreferrer) {
-   rels.add('noreferrer');
-  }
-
-  node.attrs.rel = Array.from(rels).join(' ');
- } else {
- node.attrs.rel = 'noopener nofollow external';
- }
+ // :: append rels to the element's [rel] value.
+ // failsafes in case [rel] is not defined yet.
+ const rels = node.attrs.rel
+ ? new Set(node.attrs.rel.split(/\s+/))
+ : new Set();
+
+ // config.noreferrer && rels.add('noreferrer');
+ if (config.noreferrer) rels.add('noreferrer');
+ rels.add('noopener');
+ rels.add('nofollow');
+ rels.add('external');
+
+ node.attrs.rel = Array.from(rels).join(' ');
 
  node.attrs.target = '_blank';
  }

src/index.ts

@@ -78,6 +78,30 @@ describe('posthtml-external-link', () => {
  result.should.include('" target="_blank"');
  });
 
+ it('adds noreferrer when config is set', async () => {
+ const parser = posthtml([plugin({
+ exclude: ['skk.moe'],
+ noreferrer: true
+ })]);
+
+ const input = '<a href="https://example.com" rel="example">Example</a>';
+ const { html: result } = await parser.process(input);
+
+ result.should.include(' rel="example noreferrer noopener nofollow external"');
+ });
+
+ it('adds noreferrer even to elements without an existing [rel]', async () => {
+ const parser = posthtml([plugin({
+ exclude: ['skk.moe'],
+ noreferrer: true
+ })]);
+
+ const input = '<a href="https://example.com">Example</a>';
+ const { html: result } = await parser.process(input);
+
+ result.should.include(' rel="noreferrer noopener nofollow external"');
+ });
+
  it('target attr', async () => {
  const { html: result } = await posthtml([plugin({ exclude: ['skk.moe'] })]).process('<a href="https://example.com/" target="_self">Example</a>');