Skip to content

Commit 152dbbf

Browse files
committed
Rename SignatureService to SignatureCreator
1 parent 4f920fc commit 152dbbf

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

src/main/java/de/vorb/platon/security/SignatureService.java renamed to src/main/java/de/vorb/platon/security/SignatureCreator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@
1717
package de.vorb.platon.security;
1818

1919
import lombok.RequiredArgsConstructor;
20-
import org.springframework.stereotype.Service;
20+
import org.springframework.stereotype.Component;
2121

2222
import java.time.Instant;
2323

24-
@Service
24+
@Component
2525
@RequiredArgsConstructor
26-
public class SignatureService {
26+
public class SignatureCreator {
2727

2828
private final SignatureTokenValidator signatureTokenValidator;
2929

src/main/java/de/vorb/platon/web/api/controllers/CommentController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import de.vorb.platon.persistence.CommentRepository;
2323
import de.vorb.platon.persistence.ThreadRepository;
2424
import de.vorb.platon.security.SignatureComponents;
25-
import de.vorb.platon.security.SignatureService;
25+
import de.vorb.platon.security.SignatureCreator;
2626
import de.vorb.platon.web.api.common.CommentConverter;
2727
import de.vorb.platon.web.api.common.CommentFilters;
2828
import de.vorb.platon.web.api.common.CommentSanitizer;
@@ -86,7 +86,7 @@ public class CommentController {
8686

8787
private final ThreadRepository threadRepository;
8888
private final CommentRepository commentRepository;
89-
private final SignatureService signatureService;
89+
private final SignatureCreator signatureCreator;
9090

9191
private final CommentConverter commentConverter;
9292
private final RequestValidator requestValidator;
@@ -192,7 +192,7 @@ public ResponseEntity<CommentJson> postComment(
192192
final URI commentUri = createRelativeCommentUri(comment.getId());
193193
final Instant expirationTime = comment.getCreationDate().toInstant().plus(24, HOURS);
194194
final SignatureComponents signatureComponents =
195-
signatureService.createSignatureComponents(commentUri.toString(), expirationTime);
195+
signatureCreator.createSignatureComponents(commentUri.toString(), expirationTime);
196196

197197
return ResponseEntity.created(commentUri)
198198
.header(SIGNATURE_HEADER, signatureComponents.toString())

src/test/java/de/vorb/platon/security/SignatureServiceTest.java renamed to src/test/java/de/vorb/platon/security/SignatureCreatorTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@
3030
import static org.mockito.Mockito.when;
3131

3232
@RunWith(MockitoJUnitRunner.class)
33-
public class SignatureServiceTest {
33+
public class SignatureCreatorTest {
3434

3535
@InjectMocks
36-
private SignatureService signatureService;
36+
private SignatureCreator signatureCreator;
3737

3838
@Mock
3939
private SignatureTokenValidator signatureTokenValidator;
@@ -47,7 +47,7 @@ public void usesSignatureTokenToCreateSignatureComponents() throws Exception {
4747

4848
when(signatureTokenValidator.getSignatureToken(eq(commentUri), eq(expirationTime))).thenReturn(signatureToken);
4949

50-
assertThat(signatureService.createSignatureComponents(commentUri, expirationTime))
50+
assertThat(signatureCreator.createSignatureComponents(commentUri, expirationTime))
5151
.isEqualTo(SignatureComponents.of(commentUri, expirationTime, signatureToken));
5252
}
5353

src/test/java/de/vorb/platon/web/api/controllers/CommentControllerPostTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public void createsNewThreadOnDemand() throws Exception {
6363
when(threadRepository.insert(any())).thenReturn(new ThreadsRecord().setId(1L));
6464
convertCommentJsonToRecord(commentJson, commentsRecord);
6565
when(commentsRecord.getParentId()).thenReturn(null);
66-
when(signatureService.createSignatureComponents(any(), any())).thenReturn(mock(SignatureComponents.class));
66+
when(signatureCreator.createSignatureComponents(any(), any())).thenReturn(mock(SignatureComponents.class));
6767
mockPostOrUpdateCommentRequest();
6868

6969
final ResponseEntity<CommentJson> response =

src/test/java/de/vorb/platon/web/api/controllers/CommentControllerTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import de.vorb.platon.jooq.tables.records.CommentsRecord;
2020
import de.vorb.platon.persistence.CommentRepository;
2121
import de.vorb.platon.persistence.ThreadRepository;
22-
import de.vorb.platon.security.SignatureService;
22+
import de.vorb.platon.security.SignatureCreator;
2323
import de.vorb.platon.web.api.common.CommentConverter;
2424
import de.vorb.platon.web.api.common.CommentFilters;
2525
import de.vorb.platon.web.api.common.CommentSanitizer;
@@ -62,7 +62,7 @@ public abstract class CommentControllerTest {
6262
@Mock
6363
protected CommentRepository commentRepository;
6464
@Mock
65-
protected SignatureService signatureService;
65+
protected SignatureCreator signatureCreator;
6666

6767
@Mock
6868
protected CommentConverter commentConverter;
@@ -78,7 +78,7 @@ public abstract class CommentControllerTest {
7878

7979
@Before
8080
public void setUp() throws Exception {
81-
commentController = new CommentController(clock, threadRepository, commentRepository, signatureService,
81+
commentController = new CommentController(clock, threadRepository, commentRepository, signatureCreator,
8282
commentConverter, requestValidator, commentFilters, commentSanitizer);
8383
}
8484

0 commit comments

Comments
 (0)