Skip to content

Commit 854617d

Browse files
committed
Renamed methods in TypedParameters
1 parent b2ef67c commit 854617d

File tree

9 files changed

+33
-33
lines changed

9 files changed

+33
-33
lines changed

services-api/src/main/java/io/scalecube/services/TypedParameters.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,35 +14,35 @@ public TypedParameters(Map<String, String> params) {
1414
this.params = new LinkedHashMap<>(params != null ? params : Map.of());
1515
}
1616

17-
public Integer intValue(String name) {
17+
public Integer getInt(String name) {
1818
return get(name, Integer::parseInt);
1919
}
2020

21-
public Long longValue(String name) {
21+
public Long getLong(String name) {
2222
return get(name, Long::parseLong);
2323
}
2424

25-
public BigInteger bigInteger(String name) {
25+
public BigInteger getBigInteger(String name) {
2626
return get(name, BigInteger::new);
2727
}
2828

29-
public Double doubleValue(String name) {
29+
public Double getDouble(String name) {
3030
return get(name, Double::parseDouble);
3131
}
3232

33-
public BigDecimal bigDecimal(String name) {
33+
public BigDecimal getBigDecimal(String name) {
3434
return get(name, BigDecimal::new);
3535
}
3636

37-
public <T extends Enum<T>> T enumValue(String name, Function<String, T> enumFunc) {
37+
public <T extends Enum<T>> T getEnum(String name, Function<String, T> enumFunc) {
3838
return get(name, enumFunc);
3939
}
4040

41-
public Boolean booleanValue(String name) {
41+
public Boolean getBoolean(String name) {
4242
return get(name, Boolean::parseBoolean);
4343
}
4444

45-
public String stringValue(String name) {
45+
public String getString(String name) {
4646
return get(name, s -> s);
4747
}
4848

services-api/src/test/java/io/scalecube/services/methods/StubServiceImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ public Mono<Void> invokeDynamicQualifier() {
5353
assertNotNull(context.principal(), "principal");
5454
final var pathParams = context.pathParams();
5555
assertNotNull(pathParams, "pathParams");
56-
assertNotNull(pathParams.stringValue("foo"), "pathParam[foo]");
57-
assertNotNull(pathParams.stringValue("bar"), "pathParam[bar]");
56+
assertNotNull(pathParams.getString("foo"), "pathParam[foo]");
57+
assertNotNull(pathParams.getString("bar"), "pathParam[bar]");
5858
})
5959
.then();
6060
}

services-examples/src/main/java/io/scalecube/services/examples/GreetingServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,6 @@ public Mono<ServiceMessage> emptyGreetingMessage(ServiceMessage request) {
107107
@Override
108108
public Mono<String> helloDynamicQualifier(Long value) {
109109
return RequestContext.deferContextual()
110-
.map(context -> context.pathParams().stringValue("someVar") + "@" + value);
110+
.map(context -> context.pathParams().getString("someVar") + "@" + value);
111111
}
112112
}

services-gateway/src/test/java/io/scalecube/services/gateway/files/ReportServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public Flux<ServiceMessage> successfulDownload() {
123123
.flatMapMany(
124124
context -> {
125125
final var pathParams = context.pathParams();
126-
final var fileSize = pathParams.longValue("fileSize");
126+
final var fileSize = pathParams.getLong("fileSize");
127127
final var headers = context.headers();
128128
final File file;
129129
try {

services-gateway/src/test/java/io/scalecube/services/gateway/rest/RestServiceImpl.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public Mono<SomeResponse> options() {
1919
.map(
2020
context -> {
2121
final var pathParams = context.pathParams();
22-
final var foo = pathParams.stringValue("foo");
22+
final var foo = pathParams.getString("foo");
2323
assertNotNull(foo);
2424
assertNotNull(context.headers());
2525
assertThat(context.headers().size(), greaterThan(0));
@@ -34,7 +34,7 @@ public Mono<SomeResponse> get() {
3434
.map(
3535
context -> {
3636
final var pathParams = context.pathParams();
37-
final var foo = pathParams.stringValue("foo");
37+
final var foo = pathParams.getString("foo");
3838
assertNotNull(foo);
3939
assertNotNull(context.headers());
4040
assertThat(context.headers().size(), greaterThan(0));
@@ -49,7 +49,7 @@ public Mono<SomeResponse> head() {
4949
.map(
5050
context -> {
5151
final var pathParams = context.pathParams();
52-
final var foo = pathParams.stringValue("foo");
52+
final var foo = pathParams.getString("foo");
5353
assertEquals("head123456", foo, "pathParam");
5454
final var headers = context.headers();
5555
assertNotNull(headers);
@@ -75,7 +75,7 @@ public Mono<SomeResponse> post(SomeRequest request) {
7575
.map(
7676
context -> {
7777
final var pathParams = context.pathParams();
78-
final var foo = pathParams.stringValue("foo");
78+
final var foo = pathParams.getString("foo");
7979
assertNotNull(foo);
8080
assertNotNull(context.headers());
8181
assertThat(context.headers().size(), greaterThan(0));
@@ -90,7 +90,7 @@ public Mono<SomeResponse> put(SomeRequest request) {
9090
.map(
9191
context -> {
9292
final var pathParams = context.pathParams();
93-
final var foo = pathParams.stringValue("foo");
93+
final var foo = pathParams.getString("foo");
9494
assertNotNull(foo);
9595
assertNotNull(context.headers());
9696
assertThat(context.headers().size(), greaterThan(0));
@@ -105,7 +105,7 @@ public Mono<SomeResponse> patch(SomeRequest request) {
105105
.map(
106106
context -> {
107107
final var pathParams = context.pathParams();
108-
final var foo = pathParams.stringValue("foo");
108+
final var foo = pathParams.getString("foo");
109109
assertNotNull(foo);
110110
assertNotNull(context.headers());
111111
assertThat(context.headers().size(), greaterThan(0));
@@ -120,7 +120,7 @@ public Mono<SomeResponse> delete() {
120120
.map(
121121
context -> {
122122
final var pathParams = context.pathParams();
123-
final var foo = pathParams.stringValue("foo");
123+
final var foo = pathParams.getString("foo");
124124
assertNotNull(foo);
125125
assertNotNull(context.headers());
126126
assertThat(context.headers().size(), greaterThan(0));
@@ -135,7 +135,7 @@ public Mono<SomeResponse> trace() {
135135
.map(
136136
context -> {
137137
final var pathParams = context.pathParams();
138-
final var foo = pathParams.stringValue("foo");
138+
final var foo = pathParams.getString("foo");
139139
assertNotNull(foo);
140140
assertNotNull(context.headers());
141141
assertThat(context.headers().size(), greaterThan(0));
@@ -150,9 +150,9 @@ public Mono<SomeResponse> propagateRequestAttributes() {
150150
.map(
151151
context -> {
152152
final var pathParams = context.pathParams();
153-
assertEquals(123, pathParams.intValue("foo"), "foo");
154-
assertEquals("bar456", pathParams.stringValue("bar"), "bar");
155-
assertEquals("baz789", pathParams.stringValue("baz"), "baz");
153+
assertEquals(123, pathParams.getInt("foo"), "foo");
154+
assertEquals("bar456", pathParams.getString("bar"), "bar");
155+
assertEquals("baz789", pathParams.getString("baz"), "baz");
156156

157157
final var headers = context.headers();
158158
assertEquals("GET", headers.get("http.method"));
@@ -163,13 +163,13 @@ public Mono<SomeResponse> propagateRequestAttributes() {
163163
assertEquals("2", headers.get("http.query.y"));
164164

165165
final var httpHeaders = context.headerParams("http.header");
166-
assertEquals("abc", httpHeaders.stringValue("X-String-Header"));
167-
assertEquals(123456789, httpHeaders.intValue("X-Int-Header"));
166+
assertEquals("abc", httpHeaders.getString("X-String-Header"));
167+
assertEquals(123456789, httpHeaders.getInt("X-Int-Header"));
168168

169169
final var queryParams = context.headerParams("http.query");
170-
assertEquals(true, queryParams.booleanValue("debug"));
171-
assertEquals(1, queryParams.intValue("x"));
172-
assertEquals(2, queryParams.intValue("y"));
170+
assertEquals(true, queryParams.getBoolean("debug"));
171+
assertEquals(1, queryParams.getInt("x"));
172+
assertEquals(2, queryParams.getInt("y"));
173173

174174
return new SomeResponse().name(UUID.randomUUID().toString());
175175
});

services-gateway/src/test/java/io/scalecube/services/gateway/rest/RoutingServiceImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public Mono<SomeResponse> find() {
1515
.map(
1616
context -> {
1717
final var pathParams = context.pathParams();
18-
final var foo = pathParams.stringValue("foo");
18+
final var foo = pathParams.getString("foo");
1919
assertNotNull(foo);
2020
assertNotNull(context.headers());
2121
assertTrue(context.headers().size() > 0);
@@ -30,7 +30,7 @@ public Mono<SomeResponse> update(SomeRequest request) {
3030
.map(
3131
context -> {
3232
final var pathParams = context.pathParams();
33-
final var foo = pathParams.stringValue("foo");
33+
final var foo = pathParams.getString("foo");
3434
assertNotNull(foo);
3535
assertNotNull(context.headers());
3636
assertTrue(context.headers().size() > 0);

services/src/main/java/io/scalecube/services/files/FileServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public Flux<ServiceMessage> streamFile() {
9797
context -> {
9898
final var headers = context.headers();
9999
final var pathParams = context.pathParams();
100-
final var filename = pathParams.stringValue("filename");
100+
final var filename = pathParams.getString("filename");
101101
final var path = baseDir.resolve(filename);
102102

103103
if (!isPathValid(path)) {

services/src/test/java/io/scalecube/services/PlaceholderQualifierTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ public Mono<String> hello() {
170170
@Override
171171
public Mono<String> helloWithPathParam() {
172172
return RequestContext.deferContextual()
173-
.map(context -> id + "|" + context.pathParams().stringValue("name"));
173+
.map(context -> id + "|" + context.pathParams().getString("name"));
174174
}
175175
}
176176
}

services/src/test/java/io/scalecube/services/sut/GreetingServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,6 @@ public Flux<Long> manyStream(Long cnt) {
205205
@Override
206206
public Mono<String> helloDynamicQualifier(Long value) {
207207
return RequestContext.deferContextual()
208-
.map(context -> context.pathParams().stringValue("someVar") + "@" + value);
208+
.map(context -> context.pathParams().getString("someVar") + "@" + value);
209209
}
210210
}

0 commit comments

Comments
 (0)