Skip to content

Conversation

@jsmylnycky
Copy link
Contributor

  • Added in auto-changelog module set to keepachangelog format
  • Removed last nodejitsu reference

I have note used auto-changelog before, but it seems pretty useful and the formatting it performed looked about as good as one could hope. If you would prefer a different format, just let me know and I'll be happy to change it :) It should be wired up to automatically rebuild the changelog with the correct package.json version whenever npm version is ran.

I also went through all of the most recent merges into Master and everything looked pretty good to me. The only things I caught were the nodejitsu reference, and I updated the engines block in package.json to conform to the travis-ci Node environments.

@jsmylnycky
Copy link
Contributor Author

@jcrugzz @indexzero If one of you guys can sign off on this, we can go ahead and get this merged, cut a release, and then I'll work on getting some of the other PRs reviewed & merged to master.

@jcrugzz
Copy link
Contributor

jcrugzz commented Aug 29, 2019

@jsmylnycky I think this looks reasonable. @indexzero is on vacation so lets give him a day to see if he pops on here, otherwise ill merge. Thanks for this!

@jsmylnycky
Copy link
Contributor Author

@jcrugzz @indexzero /poke :)

Copy link
Member

@indexzero indexzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't used auto-changelog, but it's certainly a nice thing to automate 👍

@jsmylnycky
Copy link
Contributor Author

Merging, feel free to cut a release when you're ready!

@jsmylnycky jsmylnycky merged commit 6e4bef4 into master Sep 5, 2019
@jcrugzz jcrugzz deleted the feature/autochangelog branch September 6, 2019 01:07
This was referenced Mar 17, 2021
Copy link

@calbearox calbearox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

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

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants