fix(options): add writeToDisk option to schema #1520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
oNaiPs requested review from alexander-akait and michael-ciniawsky as code owners 
|
|
Codecov Report
@@ Coverage Diff @@ ## master #1520 +/- ## ======================================= Coverage 74.02% 74.02% ======================================= Files 10 10 Lines 666 666 ======================================= Hits 493 493 Misses 173 173Continue to review full report at Codecov.
|
michael-ciniawsky suggested changes Oct 8, 2018
Member
michael-ciniawsky left a comment
michael-ciniawsky left a comment There was a problem hiding this comment.
@oNaiPs Thx in advance
michael-ciniawsky changed the title writeToDisk option to schema 
alexander-akait approved these changes Oct 8, 2018
Member
alexander-akait left a comment
alexander-akait left a comment There was a problem hiding this comment.
Looks good, just fix above note
Contributor Author
| @michael-ciniawsky @evilebottnawi should be good to go |
alexander-akait approved these changes Oct 10, 2018
michael-ciniawsky added status: approved and removed pr: rework priority: 3 (important) severity: 4 (inconvenient) status: pending labels 
Member
| Released in |
This was referenced Oct 23, 2018
This was referenced Mar 7, 2021
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
According to https://github.com/webpack/webpack-dev-middleware#watchoptions
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Closes #1357
Breaking Changes
None