check origin header for websocket connection #1603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sokra requested review from alexander-akait and michael-ciniawsky as code owners 
Member
| Need fix lint problems |
Codecov Report
@@ Coverage Diff @@ ## master #1603 +/- ## ========================================= + Coverage 74.06% 74.1% +0.03% ========================================= Files 10 10 Lines 671 672 +1 ========================================= + Hits 497 498 +1 Misses 174 174
Continue to review full report at Codecov.
|
This was referenced Dec 22, 2018
This was referenced Jan 1, 2019
6 tasks
ticky added a commit to buildkite/frontend that referenced this pull request Jan 30, 2019
Avoids more strict behaviour introduced by webpack/webpack-dev-server#1603
This was referenced Mar 7, 2021
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
no
Motivation / Use-Case
security fix
Breaking Changes
websocket is now checked for origin
Additional Info