Skip to content

fix: use invoke to build protos #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2024
Merged

fix: use invoke to build protos #1546

merged 4 commits into from
Jul 25, 2024

Conversation

@hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Jul 25, 2024 •
edited
Loading

Description

Fixes issue where protos files are not generated when using pyproject.toml.

In dependency installation script, we now:

  • install invoke
  • use invoke to generate the protos files
  • copy the required files to the correct location

TODO: better fix

Fixes #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines
@hallvictoria hallvictoria marked this pull request as ready for review July 25, 2024 19:49
@hallvictoria hallvictoria merged commit ce2ec9b into dev Jul 25, 2024
@hallvictoria hallvictoria deleted the hallvictoria/build-protos branch July 25, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@hallvictoria @gavin-aguiar