Implement HttpResponse support (see issue #4) #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Since we're beyond the basic prototype now, let's have @christopheranderson and @pragnagopa review the checkins. Would be good for us to get more familiar with the code and design patterns. |
Collaborator Author
| Ping. |
pragnagopa reviewed Feb 21, 2018
| @@ -0,0 +1,17 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
Nit: Move HttpTrigger tests to folder: HttpTrigger. Will make it easier to navigate when you add more tests for other triggers
Collaborator Author
There was a problem hiding this comment.
Good idea! I'll move them in a separate PR.
pragnagopa approved these changes Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See issue #4.