Make comments save again after SE DOM change, fix #23

Author: CertainPerformance

Comment-History-Checker/dist/StackCommentHistoryChecker.user.js

@@ -8,7 +8,7 @@ import * as localforageUntyped from '../node_modules/localforage/dist/localforag
 const localforage = localforageUntyped as typeof import('localforage');
 
 // Only allow a get or set operation after the previous operation is complete:
-let lastProm: Promise<SavedComments | void> = Promise.resolve();
+let lastProm: Promise<SavedComments | null> = Promise.resolve(null);
 export const getDB = async () => {
  await lastProm;
  lastProm = localforage.getItem<SavedComments>('cpuserscriptCommentHistoryCheckerSavedComments');

Comment-History-Checker/src/commentDB.ts

@@ -3,7 +3,7 @@
 // @description Review the status and reception of your comments and their parent posts
 // @author CertainPerformance
 // @namespace https://github.com/CertainPerformance/Stack-Exchange-Userscripts
-// @version 1.0.10
+// @version 1.0.11
 // @include /^https://(?:[^/]+\.)?(?:(?:stackoverflow|serverfault|superuser|stackexchange|askubuntu|stackapps)\.com|mathoverflow\.net)/(?:users/.*\?tab=activity|questions/\d|review/\w(?!.*/stats|.*/history))/
 // @grant none
 // ==/UserScript==

Comment-History-Checker/src/userscript-metadata-block.js

@@ -5,11 +5,12 @@ import { commentHrefToIds } from '../commentHrefToIds';
  * @returns True if the database was changed, otherwise false
  */
 export const saveComment = (userCommentAnchor: HTMLAnchorElement, savedComments: SavedComments) => {
- const dateElm = userCommentAnchor.nextElementSibling!.querySelector<HTMLElement>('.relativetime-clean')!;
+ const commentBody = userCommentAnchor.closest('.comment-body')!;
+ const dateElm = commentBody.querySelector<HTMLElement>('.relativetime-clean')!;
  // The title will be something like: "2020-05-12 16:08:33Z , License: CC BY-SA 4.0"
  const timestamp = new Date(dateElm.title.match(/^[^,]+?(?= ?, License)/)![0]).getTime();
  // Some sites have a MathJax preview which is the first child of the body, rather than the comment-copy being the first child
- const commentHTML = userCommentAnchor.closest('.comment-body')!.querySelector('.comment-copy')!.innerHTML;
+ const commentHTML = commentBody.querySelector('.comment-copy')!.innerHTML;
  const questionAnchor = document.querySelector('#question-header > h1 > a');
  if (!questionAnchor) {
  // Spam/rude question - it's likely already in the database, just don't try to update it
@@ -18,7 +19,7 @@ export const saveComment = (userCommentAnchor: HTMLAnchorElement, savedComments:
  const questionTitle = questionAnchor.textContent!;
  // Cannot just use .href of the comment-link below,
  // because there may be a query string which comes between the /question-title and the #commentID_postID
- const commentHrefAttrib = userCommentAnchor.parentElement!.querySelector('a.comment-link')!.getAttribute('href')!;
+ const commentHrefAttrib = commentBody.querySelector('a.comment-link')!.getAttribute('href')!;
  const commentHref = window.location.origin + window.location.pathname + commentHrefAttrib;
  const { commentId } = commentHrefToIds(commentHref);
  const newCommentObj = {

Comment-History-Checker/src/watchForCommentChanges/saveComment.ts

@@ -10,11 +10,7 @@ const defaultParamsArr = [
  ['site', thisSite],
 ];
 
-type GetApi = {
- (method: 'comments', ids: Array<number>): Promise<ApiComments>;
- (method: 'questions', ids: Array<number>): Promise<ApiQuestions>;
-};
-export const getApi: GetApi = async (method: 'comments' | 'questions', ids: Array<number>) => {
+export const getApi = async <T extends 'comments' | 'questions'>(method: T, ids: Array<number>) => {
  if (!ids.length) {
  return { items: [] };
  }
@@ -24,5 +20,5 @@ export const getApi: GetApi = async (method: 'comments' | 'questions', ids: Arra
  const url = `https://api.stackexchange.com/2.2/${method}/${ids.join(';')}${paramsString}`;
  const response = await fetch(url);
  const responseObj = await response.json();
- return responseObj;
+ return responseObj as T extends 'comments' ? ApiComments : ApiQuestions;
 };