EmitLongStrLiterals cl::opt is now global in upstream LLVM #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
LLVM upstream change: llvm/llvm-project#124856 makes EmitLongStrLiterals cl::opt global
Flakebi approved these changes Apr 15, 2025
Member
Flakebi left a comment
Flakebi left a comment There was a problem hiding this comment.
Thanks!
(Just learned due to fat fingering: Ctrl+Shift+X changes text boxes between right-to-left and left-to-right 😄)
Contributor Author
| I don't see the "Merge" button anywhere |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
LLVM upstream change: llvm/llvm-project#124856 makes EmitLongStrLiterals cl::opt global