feat: add reset to ConnectorRegistry #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ttosta-google requested review from a team, cthumuluru, kolea2 and nancynh as code owners 
enocom reviewed Nov 14, 2023
| | ||
| /** Calls shutdown on the singleton and reset the executor. */ | ||
| public void resetInstance() { | ||
| shutdown(); |
Member
There was a problem hiding this comment.
Could we update this method to close all open connectors and otherwise leave the executor running?
ttosta-google force-pushed the add-reset branch from dc254ec to f205c58 Compare enocom approved these changes Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #301