BUG: Ensure read_spss accepts pathlib Paths (GH33666) (pandas-dev#36174)

Author: drmrd

doc/source/whatsnew/v1.1.3.rst

@@ -26,6 +26,7 @@ Fixed regressions
 
 Bug fixes
 ~~~~~~~~~
+- Bug in :func:`read_spss` where passing a ``pathlib.Path`` as ``path`` would raise a ``TypeError`` (:issue:`33666`)
 - Bug in :meth:`Series.str.startswith` and :meth:`Series.str.endswith` with ``category`` dtype not propagating ``na`` parameter (:issue:`36241`)
 - Bug in :class:`Series` constructor where integer overflow would occur for sufficiently large scalar inputs when an index was provided (:issue:`36291`)
 

pandas/io/spss.py

@@ -7,6 +7,8 @@
 
 from pandas.core.api import DataFrame
 
+from pandas.io.common import stringify_path
+
 
 def read_spss(
  path: Union[str, Path],
@@ -40,6 +42,6 @@ def read_spss(
  usecols = list(usecols) # pyreadstat requires a list
 
  df, _ = pyreadstat.read_sav(
- path, usecols=usecols, apply_value_formats=convert_categoricals
+ stringify_path(path), usecols=usecols, apply_value_formats=convert_categoricals
  )
  return df

pandas/tests/io/test_spss.py

@@ -1,3 +1,5 @@
+from pathlib import Path
+
 import numpy as np
 import pytest
 
@@ -7,9 +9,10 @@
 pyreadstat = pytest.importorskip("pyreadstat")
 
 
-def test_spss_labelled_num(datapath):
+@pytest.mark.parametrize("path_klass", [lambda p: p, Path])
+def test_spss_labelled_num(path_klass, datapath):
  # test file from the Haven project (https://haven.tidyverse.org/)
- fname = datapath("io", "data", "spss", "labelled-num.sav")
+ fname = path_klass(datapath("io", "data", "spss", "labelled-num.sav"))
 
  df = pd.read_spss(fname, convert_categoricals=True)
  expected = pd.DataFrame({"VAR00002": "This is one"}, index=[0])