feat: allow conversion from float/integer to rust type i32/f64

Author: Icemic

src/errors/value_error.rs

@@ -7,6 +7,8 @@ pub enum ValueError {
  InvalidString(std::str::Utf8Error),
  /// Encountered string with \0 bytes.
  StringWithZeroBytes(std::ffi::NulError),
+ /// Value out of range.
+ OutOfRange,
  /// Internal error.
  Internal(String),
  ///
@@ -35,6 +37,7 @@ impl fmt::Display for ValueError {
  e
  ),
  StringWithZeroBytes(_) => write!(f, "String contains \\0 bytes",),
+ OutOfRange => write!(f, "Value conversion failed - out of range"),
  Internal(e) => write!(f, "Value conversion failed - internal error: {}", e),
  BigIntOverflow => write!(f, "BigInt overflow"),
  UnexpectedType => write!(f, "Could not convert - received unexpected type"),

src/value/value.rs

@@ -489,15 +489,33 @@ impl TryFrom<OwnedJsValue> for i32 {
  type Error = ValueError;
 
  fn try_from(value: OwnedJsValue) -> Result<Self, Self::Error> {
- value.to_int()
+ if value.is_int() {
+ return value.to_int();
+ } else if value.is_float() {
+ let f = value.to_float()?;
+ if f.fract() != 0.0 {
+ return Err(ValueError::UnexpectedType);
+ }
+ if f < (i32::MIN as f64) || f > (i32::MAX as f64) {
+ return Err(ValueError::OutOfRange);
+ }
+ return Ok(f as i32);
+ }
+ Err(ValueError::UnexpectedType)
  }
 }
 
 impl TryFrom<OwnedJsValue> for f64 {
  type Error = ValueError;
 
  fn try_from(value: OwnedJsValue) -> Result<Self, Self::Error> {
- value.to_float()
+ if value.is_float() {
+ return value.to_float();
+ } else if value.is_int() {
+ let i = value.to_int()?;
+ return Ok(i as f64);
+ }
+ Err(ValueError::UnexpectedType)
  }
 }