Skip to content

Commit 771fb8b

Browse files
committed
matching css for chrome and firefox
1 parent add8727 commit 771fb8b

File tree

3 files changed

+41
-6
lines changed

3 files changed

+41
-6
lines changed

index.css

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,19 @@ body {
99
img {
1010
vertical-align: bottom; /* solution for space under image */
1111
}
12+
input[type="text"] {
13+
height: 18px; /* chrome - firefox */
14+
line-height: 18px; /* chrome - firefox */
15+
}
16+
select {
17+
vertical-align: top;
18+
height: 20px; /* chrome - firefox */
19+
line-height: 20px; /* chrome - firefox */
20+
}
1221
button {
13-
padding: 0 5px;
22+
background-color: gainsboro; /* chrome - firefox */
23+
border-width: 1px; /* chrome - firefox */
24+
padding: 1px 5px;
1425
}
1526
.task-textarea {
1627
resize: none;
@@ -51,13 +62,15 @@ button {
5162
background-color: gainsboro;
5263
margin-bottom: 5px;
5364
}
65+
/*
5466
.task-top-row-span-select {
5567
vertical-align: top;
5668
display: inline-block;
5769
padding: 2px 5px 1px 5px;
5870
background-color: gainsboro;
5971
margin-bottom: 5px;
6072
}
73+
/**/
6174
.task-top-row-button {
6275
margin-bottom: 5px;
6376
}

index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@
8181
<div class="task-top-row">
8282
<span v-if="expanded" class="task-top-row-span">
8383
<img src="icons/increase.png" alt="Task priority factor" title="Task priority factor" height="20" width="20">
84-
<input ref="factor" v-on:input="inputAdjust()" v-model="newTaskFactor" aria-label="Task factor" class="task-top-row-input" />%
84+
<input type="text" ref="factor" v-on:input="inputAdjust()" v-model="newTaskFactor" aria-label="Task factor" class="task-top-row-input" />%
8585
</span>
86-
<span v-if="expanded" class="task-top-row-span-select">
86+
<span v-if="expanded" class="task-top-row-span">
8787
<img src="icons/tag.png" alt="Task group" title="Task group" height="20" width="20">
8888
<select v-model="newTaskGroup">
8989
<option v-for="(value, key) in taskGroups" v-bind:value="key" v-bind:style="{ 'background-color': value }">

index.js

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,17 @@ Vue.directive('click-outside', {
5858
},
5959
});
6060

61+
// TODO:: fix css for firefox
62+
63+
// https://stackoverflow.com/questions/2954659/css-size-of-buttons-in-chrome-is-different-than-firefox
64+
65+
// https://stackoverflow.com/questions/7229568/input-height-differences-in-firefox-and-chrome
66+
// https://stackoverflow.com/questions/6184210/how-can-i-control-the-height-of-text-inputs-and-submit-input-buttons-in-differen
67+
// https://stackoverflow.com/questions/18582606/input-field-chrome-and-firefox-shows-different
68+
69+
// https://stackoverflow.com/questions/20477823/select-html-element-with-height
70+
// https://stackoverflow.com/questions/2547354/how-to-standardize-the-height-of-a-select-box-between-chrome-and-firefox
71+
6172
// TODO:: pwa - chrome developer tools - audit - lighthouse:
6273
// HTTPS
6374
// HTTP/2
@@ -91,7 +102,18 @@ Vue.directive('click-outside', {
91102
// TODO::LATER completed: too soon / on time / too late --> auto priority adjustment
92103
// TODO::LATER suggested priority
93104

105+
// TODO:: #0 change <textarea> to <div contenteditable="true">
94106
// TODO:: #1 parse URL
107+
108+
// https://stackoverflow.com/questions/37684/how-to-replace-plain-urls-with-links
109+
110+
// https://stackoverflow.com/questions/19214453/rich-text-editor-replacement-for-html-textarea
111+
// https://stackoverflow.com/questions/17785845/convert-html-tag-in-textarea-to-rich-text
112+
// https://stackoverflow.com/questions/2580247/can-i-embed-html-formatting-inside-of-a-textarea-tag
113+
// https://stackoverflow.com/questions/10404312/html5-rich-text-inside-textarea
114+
115+
// https://github.com/guardian/scribe
116+
95117
// https://github.com/SoapBox/linkifyjs
96118
// https://github.com/nfrasser/linkify-shim/blob/master/linkify.min.js
97119
// https://github.com/phanan/vue-linkify
@@ -172,9 +194,9 @@ Vue.component('task-item', {
172194
</span>
173195
<span v-if="expanded" class="task-top-row-span">
174196
<img src="icons/increase.png" alt="Task priority factor" title="Task priority factor" height="20" width="20">
175-
<input ref="factor" v-on:input="inputAdjust()" :value="priorityFactor" @input="$emit('update:priority-factor', $event.target.value)" aria-label="Task factor" class="task-top-row-input" />%
197+
<input type="text" ref="factor" v-on:input="inputAdjust()" :value="priorityFactor" @input="$emit('update:priority-factor', $event.target.value)" aria-label="Task factor" class="task-top-row-input" />%
176198
</span>
177-
<span v-if="expanded" class="task-top-row-span-select">
199+
<span v-if="expanded" class="task-top-row-span">
178200
<img src="icons/tag.png" alt="Task group" title="Task group" height="20" width="20">
179201
<select :value="group" @input="$emit('update:group', $event.target.value)">
180202
<option v-for="(value, key) in this.$parent.taskGroups" v-bind:value="key" v-bind:style="{ 'background-color': value }">
@@ -299,7 +321,7 @@ new Vue({
299321

300322
selectedGroup: 'all',
301323
taskGroups: {
302-
'all': "lightgray",
324+
'all': "silver",
303325
'relax / enjoy': "#d7fea8",
304326
'cook / eat': "#fefea6",
305327
'chores': "#feda9c",

0 commit comments

Comments
 (0)