Skip to content

Commit 0304dbc

Browse files
janlindstromsysprg
authored andcommitted
MDEV-25089 : Assertion `error.len > 0' failed in galera::ReplicatorSMM::handle_apply_error()
Additional corrections after merge from 10.4 branch Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>
1 parent 9fb8881 commit 0304dbc

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

mysql-test/suite/galera/disabled.def

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ galera_concurrent_ctas : MDEV-32779 galera_concurrent_ctas: assertion in the gal
1818
galera_as_slave_replay : MDEV-32780 galera_as_slave_replay: assertion in the wsrep::transaction::before_rollback()
1919
galera_slave_replay : MDEV-32780 galera_as_slave_replay: assertion in the wsrep::transaction::before_rollback()
2020
galera_sst_mysqldump_with_key : MDEV-32782 galera_sst_mysqldump_with_key test failed
21-
mdev-31285 : MDEV-25089 Assertion `error.len > 0' failed in galera::ReplicatorSMM::handle_apply_error()
2221
galera_var_ignore_apply_errors : MENT-1997 galera_var_ignore_apply_errors test freezes
2322
MDEV-22232 : temporarily disabled at the request of Codership
2423
MW-402 : temporarily disabled at the request of Codership

mysql-test/suite/galera/t/mdev-30013.test

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
--source include/galera_cluster.inc
2+
--source include/force_restart.inc # ARCHIVE plugin must be uninstalled
23

34
if (!$HA_ARCHIVE_SO) {
45
skip Needs Archive loadable plugin;

sql/sql_table.cc

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10294,14 +10294,14 @@ bool mysql_alter_table(THD *thd, const LEX_CSTRING *new_db,
1029410294
if we can support implementing storage engine.
1029510295
*/
1029610296
if (WSREP(thd) && table && table->s->sequence &&
10297-
wsrep_check_sequence(thd, thd->lex->create_info.seq_create_info, used_engine))
10297+
wsrep_check_sequence(thd, create_info->seq_create_info, used_engine))
1029810298
DBUG_RETURN(TRUE);
1029910299

10300-
if (WSREP(thd) &&
10300+
if (WSREP(thd) && table &&
1030110301
(thd->lex->sql_command == SQLCOM_ALTER_TABLE ||
1030210302
thd->lex->sql_command == SQLCOM_CREATE_INDEX ||
1030310303
thd->lex->sql_command == SQLCOM_DROP_INDEX) &&
10304-
!wsrep_should_replicate_ddl(thd, table_list->table->s->db_type()->db_type))
10304+
!wsrep_should_replicate_ddl(thd, table->s->db_type()->db_type))
1030510305
DBUG_RETURN(true);
1030610306
#endif /* WITH_WSREP */
1030710307

@@ -12539,12 +12539,10 @@ bool Sql_cmd_create_table_like::execute(THD *thd)
1253912539
wsrep_check_sequence(thd, lex->create_info.seq_create_info, used_engine))
1254012540
DBUG_RETURN(true);
1254112541

12542-
WSREP_TO_ISOLATION_BEGIN_ALTER(create_table->db.str,
12543-
create_table->table_name.str,
12544-
first_table, &alter_info, NULL,
12545-
&create_info)
12546-
{
12547-
WSREP_WARN("CREATE TABLE isolation failure");
12542+
WSREP_TO_ISOLATION_BEGIN_ALTER(create_table->db.str, create_table->table_name.str,
12543+
first_table, &alter_info, NULL, &create_info)
12544+
{
12545+
WSREP_WARN("CREATE TABLE isolation failure");
1254812546
res= true;
1254912547
goto end_with_restore_list;
1255012548
}

0 commit comments

Comments
 (0)