Add .mill-version file #7
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add
.mill-versionfile to fix the mill version to 0.11.6.Motivation:
When I try to run
make verilogwith the latest mill (0.11.7) (+openjdk11/17/19), the following error occurs:After drilling into the source code for mill and chisel, I'm guessing that the problem is caused by mill 0.11.7 changing the way it handles short arguments, treating
-tdas combined short arguments-t -d.This was introduced by com-lihaoyi/mill/pull/2990, in which a
mainargsmodule was updated from 0.5.4 to 0.6.1. This update included changes that allow short arguments and flags to be combined, refer to com-lihaoyi/mainargs/pull/102.There are two temporary solutions to the problem, one is to replace
-tdwith--target-dirin Makefile, and the other is to downgrade the mill to 0.11.6, which is the latest version without the problem.In order to ensure the out-of-the-box nature of this repository, and to avoid similar issues of being broken by tool version updates in the future, I think adding a
.mill-versionfile is a good idea, and thus issue this PR.