Merge pull request #75 from PHPCompatibility/feature/ruleset-prevent-ignoring-too-much

Polyfills 8.4/8.5: remove overzealous exclusion

Author: jrfnl

PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml

@@ -24,10 +24,7 @@
  <!--
  Detection for the Deprecated attribute is incomplete in PHPCompatibility 10.0.0-alpha1.
  Handling for this should be added once the detection implementation is known.
- The following exclude is a temporary placeholder, which should be removed as soon as
- possible as it will ignore too much.
  -->
- <exclude name="PHPCompatibility.Attributes.NewAttributes.PHPStormAttributeFound"/>
 
  <exclude name="PHPCompatibility.Classes.NewClasses.reflectionconstantFound"/>
  </rule>

PHPCompatibilitySymfonyPolyfillPHP85/ruleset.xml

@@ -14,10 +14,7 @@
  <!--
  Detection for the DelayedTargetValidation and NoDiscard attributes is incomplete in PHPCompatibility 10.0.0-alpha1.
  This section should be filled out once the detection implementation is known.
- The following exclude is a temporary placeholder, which should be removed as soon as
- possible as it will ignore too much.
  -->
- <exclude name="PHPCompatibility.Attributes.NewAttributes.Found"/>
  </rule>
 
  <!-- Prevent false positives being thrown when run over the code of polyfill-php84 itself. -->

Test/SymfonyPolyfillPHP84Test.php

@@ -24,5 +24,9 @@
 
 $r = new ReflectionConstant(ClassName::CONSTANT_NAME);
 
+/*
+// This test will not help at this time as we can't just ignore the use of the Deprecated attribute
+// with the current attribute handling in PHPCompatibility 10.0.
 #[Deprecated]
 function foo() {}
+*/

Test/SymfonyPolyfillPHP85Test.php

@@ -8,6 +8,10 @@
 array_first($array);
 array_last($array);
 
+/*
+// This test will not help at this time as we can't just ignore the use of the DelayedTargetValidation/NoDiscard attribute
+// with the current attribute handling in PHPCompatibility 10.0.
 #[DelayedTargetValidation]
 #[NoDiscard]
 function dummy() {}
+*/