build: use ts_library macro with common defaults

Author: filipesilva

packages/angular/cli/BUILD.bazel

@@ -3,13 +3,13 @@
 # Use of this source code is governed by an MIT-style license that can be
 # found in the LICENSE file at https://angular.io/license
 
-licenses(["notice"]) # MIT
-
 load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar")
-load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
 load("//tools:ts_json_schema.bzl", "ts_json_schema")
+load("//tools:defaults.bzl", "ts_library")
+
+licenses(["notice"]) # MIT
 
 licenses(["notice"]) # MIT
 
@@ -47,8 +47,6 @@ ts_library(
  "**/*.json",
  "**/*.md",
  ]),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  module_name = "@angular/cli",
  # strict_checks = False,
  deps = [
@@ -231,15 +229,10 @@ ts_library(
  name = "angular-cli_test_lib",
  testonly = True,
  srcs = glob(["**/*_spec.ts"]),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  # strict_checks = False,
- tsconfig = "//:tsconfig-test.json",
  deps = [
  ":angular-cli",
  "//packages/angular_devkit/core",
- "@npm//@types/jasmine",
- "@npm//@types/node",
  ],
 )
 

packages/angular/pwa/BUILD.bazel

@@ -3,12 +3,14 @@
 # Use of this source code is governed by an MIT-style license that can be
 # found in the LICENSE file at https://angular.io/license
 
-load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
+load("//tools:defaults.bzl", "ts_library")
 load("//tools:ts_json_schema.bzl", "ts_json_schema")
 
 licenses(["notice"]) # MIT
 
+licenses(["notice"]) # MIT
+
 package(default_visibility = ["//visibility:public"])
 
 ts_library(
@@ -35,8 +37,6 @@ ts_library(
  "pwa/files/**/*",
  ],
  ),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  deps = [
  "//packages/angular_devkit/core",
  "//packages/angular_devkit/schematics",
@@ -56,15 +56,10 @@ ts_library(
  name = "pwa_test_lib",
  testonly = True,
  srcs = glob(["pwa/**/*_spec.ts"]),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  # strict_checks = False,
- tsconfig = "//:tsconfig-test.json",
  deps = [
  ":pwa",
  "//packages/angular_devkit/schematics/testing",
- "@npm//@types/jasmine",
- "@npm//@types/node",
  ],
 )
 

packages/angular_devkit/architect/BUILD.bazel

@@ -5,7 +5,7 @@
 
 load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar")
 load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
-load("@npm_bazel_typescript//:index.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 # @external_begin
 load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
@@ -50,8 +50,6 @@ ts_library(
  ],
  # strict_checks = False,
  data = glob(["**/*.json"]),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  module_name = "@angular-devkit/architect",
  module_root = "src/index.d.ts",
  deps = [
@@ -66,16 +64,11 @@ ts_library(
  name = "architect_test_lib",
  testonly = True,
  srcs = glob(["src/**/*_spec.ts"]),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  # strict_checks = False,
- tsconfig = "//:tsconfig-test.json",
  deps = [
  ":architect",
  "//packages/angular_devkit/architect/testing",
  "//packages/angular_devkit/core",
- "@npm//@types/jasmine",
- "@npm//@types/node",
  "@npm//rxjs",
  ],
 )

packages/angular_devkit/architect/node/BUILD.bazel

@@ -3,7 +3,9 @@
 # Use of this source code is governed by an MIT-style license that can be
 # found in the LICENSE file at https://angular.io/license
 
-load("@npm_bazel_typescript//:index.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
+
+licenses(["notice"]) # MIT
 
 licenses(["notice"]) # MIT
 
@@ -15,8 +17,6 @@ ts_library(
  include = ["**/*.ts"],
  exclude = ["**/*_spec.ts"],
  ),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  module_name = "@angular-devkit/architect/node",
  module_root = "index.d.ts",
  # strict_checks = False,

packages/angular_devkit/architect/testing/BUILD.bazel

@@ -3,7 +3,9 @@
 # Use of this source code is governed by an MIT-style license that can be
 # found in the LICENSE file at https://angular.io/license
 
-load("@npm_bazel_typescript//:index.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
+
+licenses(["notice"]) # MIT
 
 licenses(["notice"]) # MIT
 
@@ -15,8 +17,6 @@ ts_library(
  include = ["**/*.ts"],
  exclude = ["**/*_spec.ts"],
  ),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  module_name = "@angular-devkit/architect/testing",
  module_root = "index.d.ts",
  deps = [

packages/angular_devkit/architect_cli/BUILD.bazel

@@ -1,20 +1,18 @@
-load("@npm_bazel_typescript//:index.bzl", "ts_library")
+load("//tools:defaults.bzl", "ts_library")
 
 # Copyright Google Inc. All Rights Reserved.
 #
 # Use of this source code is governed by an MIT-style license that can be
 # found in the LICENSE file at https://angular.io/license
-package(default_visibility = ["//visibility:public"])
-
 licenses(["notice"]) # MIT
 
+package(default_visibility = ["//visibility:public"])
+
 ts_library(
  name = "architect_cli",
  srcs = [
  "bin/architect.ts",
  ] + glob(["src/**/*.ts"]),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  module_name = "@angular-devkit/architect-cli",
  deps = [
  "//packages/angular_devkit/architect",

packages/angular_devkit/benchmark/BUILD.bazel

@@ -5,8 +5,8 @@
 
 load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar")
 load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
-load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
+load("//tools:defaults.bzl", "ts_library")
 
 licenses(["notice"]) # MIT
 
@@ -21,8 +21,6 @@ ts_library(
  "src/**/*_benchmark.ts",
  ],
  ),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  module_name = "@angular-devkit/benchmark",
  module_root = "src/index.d.ts",
  deps = [
@@ -46,16 +44,11 @@ ts_library(
  "src/test/watch-test-file.txt",
  "src/test/watch-test-script.js",
  ],
- devmode_module = "commonjs",
- devmode_target = "es2018",
  # @external_begin
- tsconfig = "//:tsconfig-test.json",
  deps = [
  ":benchmark",
  "//packages/angular_devkit/core",
  "//packages/angular_devkit/core/node",
- "@npm//@types/jasmine",
- "@npm//@types/node",
  "@npm//rxjs",
  ],
  # @external_end

packages/angular_devkit/build_angular/BUILD.bazel

@@ -3,14 +3,14 @@
 # Use of this source code is governed by an MIT-style license that can be
 # found in the LICENSE file at https://angular.io/license
 
-licenses(["notice"]) # MIT
-
 load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar")
-load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
+load("//tools:defaults.bzl", "ts_library")
 load("//tools:ts_json_schema.bzl", "ts_json_schema")
 
+licenses(["notice"]) # MIT
+
 package(default_visibility = ["//visibility:public"])
 
 ts_json_schema(
@@ -84,8 +84,6 @@ ts_library(
  "src/**/*.html",
  ],
  ),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  module_name = "@angular-devkit/build-angular",
  module_root = "src/index.d.ts",
  deps = [
@@ -191,16 +189,11 @@ ts_library(
  ],
  ),
  data = glob(["test/**/*"]),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  # strict_checks = False,
- tsconfig = "//:tsconfig-test.json",
  deps = [
  ":build_angular",
  "//packages/angular_devkit/architect/testing",
  "//packages/angular_devkit/core",
- "@npm//@types/jasmine",
- "@npm//@types/node",
  "@npm//@types/webpack",
  "@npm//typescript",
  "@npm//webpack",
@@ -234,8 +227,6 @@ ts_library(
  testonly = True,
  srcs = [":src/test-utils.ts"],
  data = glob(["test/**/*"]),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  tsconfig = "//:tsconfig-test.json",
  deps = [
  ":build_angular",
@@ -244,8 +235,6 @@ ts_library(
  "//packages/angular_devkit/architect/testing",
  "//packages/angular_devkit/core",
  "//packages/angular_devkit/core/node",
- "@npm//@types/jasmine",
- "@npm//@types/node",
  ],
 )
 
@@ -327,8 +316,6 @@ LARGE_SPECS = {
  name = "build_angular_" + spec + "_test_lib",
  testonly = True,
  srcs = glob(["src/" + spec + "/**/*_spec.ts"]),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  tsconfig = "//:tsconfig-test.json",
  deps = [
  # Dependencies needed to compile and run the specs themselves.
@@ -339,8 +326,6 @@ LARGE_SPECS = {
  "//packages/angular_devkit/architect/testing",
  "//packages/angular_devkit/core",
  "//packages/angular_devkit/core/node",
- "@npm//@types/jasmine",
- "@npm//@types/node",
 
  # Base dependencies for the application in hello-world-app.
  # Some tests also require extra dependencies.

packages/angular_devkit/build_ng_packagr/BUILD.bazel

@@ -3,14 +3,14 @@
 # Use of this source code is governed by an MIT-style license that can be
 # found in the LICENSE file at https://angular.io/license
 
-licenses(["notice"]) # MIT
-
 load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar")
-load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
+load("//tools:defaults.bzl", "ts_library")
 load("//tools:ts_json_schema.bzl", "ts_json_schema")
 
+licenses(["notice"]) # MIT
+
 package(default_visibility = ["//visibility:public"])
 
 ts_json_schema(
@@ -33,8 +33,6 @@ ts_library(
  "src/build/schema.json",
  ],
  ),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  module_name = "@angular-devkit/build-ng-packagr",
  module_root = "src/index.d.ts",
  deps = [
@@ -70,9 +68,6 @@ ts_library(
  ],
  ),
  data = glob(["test/**/*"]),
- devmode_module = "commonjs",
- devmode_target = "es2018",
- tsconfig = "//:tsconfig-test.json",
  deps = [
  ":build_ng_packagr",
  "//packages/angular_devkit/architect",
@@ -86,8 +81,6 @@ ts_library(
  "@npm//@angular/platform-browser",
  "@npm//@angular/platform-browser-dynamic",
  "@npm//@angular/router",
- "@npm//@types/jasmine",
- "@npm//@types/node",
  "@npm//ng-packagr",
  "@npm//rxjs",
  "@npm//tslib",

packages/angular_devkit/build_optimizer/BUILD.bazel

@@ -5,8 +5,8 @@
 
 load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar")
 load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
-load("@npm_bazel_typescript//:index.bzl", "ts_library")
 load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm")
+load("//tools:defaults.bzl", "ts_library")
 
 licenses(["notice"]) # MIT
 
@@ -30,8 +30,6 @@ ts_library(
  "webpack-loader/package.json",
  ],
  ),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  module_name = "@angular-devkit/build-optimizer",
  module_root = "src/index.d.ts",
  deps = [
@@ -48,15 +46,10 @@ ts_library(
  name = "build_optimizer_test_lib",
  testonly = True,
  srcs = glob(["src/**/*_spec.ts"]),
- devmode_module = "commonjs",
- devmode_target = "es2018",
  # @external_begin
- tsconfig = "//:tsconfig-test.json",
  deps = [
  ":build_optimizer",
  "//packages/angular_devkit/core",
- "@npm//@types/jasmine",
- "@npm//@types/node",
  "@npm//source-map",
  ],
  # @external_end