JAVA-3109, JAVA-2980: Support binding collections of attributes in IN clause query builder #1935
+155 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… clause query builder
tolbertam approved these changes Sep 20, 2024
Contributor
tolbertam left a comment
tolbertam left a comment There was a problem hiding this comment.
Looks good to me, thanks! Just two tiny nits with the javadocs, 👍
core/src/main/java/com/datastax/oss/driver/api/core/type/codec/TypeCodec.java Outdated Show resolved Hide resolved
core/src/main/java/com/datastax/oss/driver/api/core/type/codec/TypeCodec.java Outdated Show resolved Hide resolved
…/TypeCodec.java Co-authored-by: Andrew Tolbert <6889771+tolbertam@users.noreply.github.com>
…/TypeCodec.java Co-authored-by: Andrew Tolbert <6889771+tolbertam@users.noreply.github.com>
tolbertam approved these changes Sep 20, 2024
Contributor
tolbertam left a comment
tolbertam left a comment There was a problem hiding this comment.
Thanks for incorporating those changes 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
JIRA Links: