Switch Basic Authentication encoding to UTF-8 #1970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ppkarwasz force-pushed the basic-auth branch from a02f585 to 8be8a94 Compare 
ppkarwasz force-pushed the basic-auth branch from 8be8a94 to ac29f8f Compare 
vy approved these changes Nov 16, 2023
log4j-core/src/main/java/org/apache/logging/log4j/core/util/BasicAuthorizationProvider.java Show resolved Hide resolved
dongjoon-hyun pushed a commit to apache/spark that referenced this pull request Nov 22, 2023
### What changes were proposed in this pull request? The pr aims to upgrade log4j2 from 2.21.0 to 2.22.0. ### Why are the changes needed? This is the first log4j2 version that provides a CycloneDX Software Bill of Materials (SBOM) and the new version bring some new change and fix like: - Change the order of evaluation of FormattedMessage formatters. Messages are evaluated using java.util.Format only if they don't comply to the java.text.MessageFormat or ParameterizedMessage format. (apache/logging-log4j2#1223) - Change default encoding of HTTP Basic Authentication to UTF-8 and add log4j2.configurationAuthorizationEncoding property to overwrite it. (apache/logging-log4j2#1970) - Removed unused FastDateParser which was causing unnecessary heap overhead ([LOG4J2-3672](https://issues.apache.org/jira/browse/LOG4J2-3672), apache/logging-log4j2#1848) - Fix MDC pattern converter causing issues for %notEmpty (apache/logging-log4j2#1922) - Fix NotSerializableException thrown when Logger is serialized with a ReusableMessageFactory (apache/logging-log4j2#1884) the full release note as follows: -https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.22.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #43940 from LuciferYang/SPARK-46038. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
RFC 7617 introduces a new
charsetparameter for the Basic authentication scheme with a single allowed value "UTF-8".Clients that comply to this RFC should encode the user name and password using UTF-8 if the parameter is present. Clients that always use UTF-8 obviously comply to this rule.
Up until now Log4j used the system encoding for Basic authentication. This PR:
log4j2.configurationAuthorizationEncodingproperty to overwrite the default value.This problem was detected by Error Prone in #1961.