Skip to content

Sema: Don't talk about @_versioned in diagnostics for default arguments [4.0] #10348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2017
Merged

Sema: Don't talk about @_versioned in diagnostics for default arguments [4.0] #10348

merged 1 commit into from
Jun 18, 2017

Conversation

@slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Jun 17, 2017 •
edited
Loading

  • Description: Just a cosmetic fix, don't talk about @_versioned in diagnostics pertaining to default arguments.

  • Origination: Swift 3.1 added resilience diagnostics for inlineable code, which is not an officially supported feature, but in Swift 4 we switched these checks on for default argument expressions as well, so they should not talk about internal attributes.

  • Risk: None, hopefully.

  • Tested: Test updated for new diagnostic strings.

  • Reviewed by: @jrose-apple

  • Radar: Fixes rdar://problem/32445206.
@slavapestov
Copy link
Contributor Author

slavapestov commented Jun 17, 2017

@swift-ci Please test
@slavapestov
Copy link
Contributor Author

slavapestov commented Jun 17, 2017

@jrose-apple Can you take a look please?
@ematejska ematejska merged commit ec63e10 into swiftlang:swift-4.0-branch Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@slavapestov @jrose-apple @ematejska